Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #28803 (GenParticles2HepMC with exotic LHE) #28856

Merged

Conversation

mseidel42
Copy link
Contributor

@mseidel42 mseidel42 commented Feb 3, 2020

PR description:

Fixes crash in GenParticles2HepMCConverter (#28803) by adding fake beam particles for exotic LHE files with only one beam-particle candidate. This was used for NeutrinoGun samples (no beam particles) before.

PR validation:

  • Processed NanoAod from problematic events
  • Processed MiniAod events to produce Rivet histograms

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #28876

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2020

A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/RivetInterface

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

srimanob commented Feb 6, 2020

@intrepid42
Which workflow you are testing?
I assume we did not run Run-2 workflows anymore, I can have a look.

@mseidel42
Copy link
Contributor Author

Hi Phat, I just tried your NanoAOD_PPS_cfg.py in CMSSW 11_1_X. I fixed the general Rivet problem there, so I will do the PR to master soon.

@qliphy
Copy link
Contributor

qliphy commented Feb 11, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4589/console Started: 2020/02/11 10:01

@cmsbuild
Copy link
Contributor

+1
Tested at: c1d6266
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be271a/4589/summary.html
CMSSW: CMSSW_10_2_X_2020-02-10-2300
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be271a/4589/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007491
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007298
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Feb 11, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
please make a backport also for 10_6_x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants