Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phi-dependent JEC uncertainties [10_6_X backport] #28867

Merged
merged 1 commit into from Feb 12, 2020

Conversation

ahinzmann
Copy link
Contributor

Backport of #28864

PR description:

Fix issue #28860.
This has no impact on any CMS workflow, since JEC uncertainty have never had phi-dependence.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This may have an impact once we introduce corrections for 2018-HEM issue, thus backport down to 10_2 releases.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2020

A new Pull Request was created by @ahinzmann for CMSSW_10_6_X.

It involves the following packages:

CondFormats/JetMETObjects

@ggovi, @cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mmusich, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@santocch
Copy link

santocch commented Feb 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4551/console Started: 2020/02/07 15:40

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

+1
Tested at: d614e99
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14cf93/4551/summary.html
CMSSW: CMSSW_10_6_X_2020-02-07-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14cf93/4551/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211989
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@silviodonato
Copy link
Contributor

hold
waiting for #28864

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Feb 10, 2020
@silviodonato
Copy link
Contributor

bugfix

@silviodonato
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Feb 11, 2020
@ggovi
Copy link
Contributor

ggovi commented Feb 11, 2020

+1

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5338ff8 into cms-sw:CMSSW_10_6_X Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants