Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOCAL_DEBUG in MuonBaseNumber.cc restored #28921

Merged
merged 3 commits into from Feb 12, 2020
Merged

LOCAL_DEBUG in MuonBaseNumber.cc restored #28921

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7beb24
test again
slomeo Feb 11, 2020
be20669
cod format applied
slomeo Feb 11, 2020
7c1cfe9
restored //#define LOCAL_DEBUG
slomeo Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions Geometry/MuonNumbering/src/MuonBaseNumber.cc
View file
Open in desktop
@@ -1,7 +1,7 @@
#include "Geometry/MuonNumbering/interface/MuonBaseNumber.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"

//#define LOCAL_DEBUG
#define LOCAL_DEBUG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slomeo Please explain this change. It turns on the debug statements. The problem in #28796 was that the debug statements were effectively turned on. I think you want to turn OFF the debug statements, which means this line should remain commented out. Am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvuosalo : The change is made to answer to @fabiocos (see #28796)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slomeo But how does it answer Fabio's request? It seems to do the opposite of what he requested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvuosalo I could make a test: restore the version where only the line 4 is commented (i.e //#define LOCAL_DEBUG)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as Fabio suggested, please make a version where only line 4 is commented.
It should appear like the left side of https://github.com/cms-sw/cmssw/pull/28796/files/a6175cdc9b547560bede5f274e12ca51e431d5dd#diff-47cb6cf59007852c622e5f745bab812dL4-L42

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slomeo I am afraid you misinterpreted my suggestion, we want to silence the messages but keep the possibility to switch them on, not to enable them by default

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define LOCAL_DEBUG
//#define LOCAL_DEBUG


void MuonBaseNumber::addBase(const LevelBaseNumber& num) {
basenumber_type::iterator cur = sortedBaseNumber.begin();
Expand Down Expand Up @@ -29,7 +29,7 @@ void MuonBaseNumber::addBase(const LevelBaseNumber& num) {
}
sortedBaseNumber.insert(cur, num);

//#ifdef LOCAL_DEBUG
#ifdef LOCAL_DEBUG
cur = sortedBaseNumber.begin();
end = sortedBaseNumber.end();
edm::LogVerbatim("Geometry") << "MuonBaseNumber::AddBase ";
Expand All @@ -39,7 +39,7 @@ void MuonBaseNumber::addBase(const LevelBaseNumber& num) {
cur++;
++k;
}
//#endif
#endif
}

void MuonBaseNumber::addBase(const int level, const int super, const int base) {
Expand Down