Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOCAL_DEBUG in MuonBaseNumber.cc restored #28921

Merged
merged 3 commits into from Feb 12, 2020

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented Feb 11, 2020

PR description:

Restored #ifdef LOCAL_DEBUG in MuonBaseNumber.cc as requested by @fabiocos

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@slomeo
Copy link
Contributor Author

slomeo commented Feb 11, 2020

@fabiocos : as you requested

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28921/13716

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28921/13720

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Geometry/MuonNumbering

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4597/console Started: 2020/02/11 15:24

@silviodonato
Copy link
Contributor

Remember to update the title of this PR. It should fix the unit test in Geometry/DTGeometryBuilder (#28796 (comment))

@cmsbuild
Copy link
Contributor

+1
Tested at: be20669
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8f3fe/4597/summary.html
CMSSW: CMSSW_11_1_X_2020-02-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28921/13731

  • This PR adds an extra 12KB to repository

@silviodonato
Copy link
Contributor

please test with 28875

@cmsbuild
Copy link
Contributor

Pull request #28921 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

@silviodonato
Copy link
Contributor

ping @cmsbuild

@silviodonato
Copy link
Contributor

please test with 28875

@silviodonato
Copy link
Contributor

please test with #28875

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #28875
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4622/console Started: 2020/02/12 15:46

@cmsbuild
Copy link
Contributor

+1
Tested at: 7c1cfe9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-293cea/4622/summary.html
CMSSW: CMSSW_11_1_X_2020-02-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-293cea/4622/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2694005
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2693658
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

merge
FYI geometry: @Dr15Jones @civanch @cvuosalo @ianna @makortel @mdhildreth

@cmsbuild cmsbuild merged commit 30b42eb into cms-sw:master Feb 12, 2020
@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants