[DD4hep] DDNamespace::name Issue #28949

[ianna]

PR description:

• Use DDNamespace::prepend(name) instead of DDNamespace::name() in all std::string operations.
• Remove unused std::strings

Addresses issue #28949 and replaces PR #28933

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28951/13766

• This PR adds an extra 68KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/plugins/dd4hep/DDAngular.cc modified in PR(s): Fix string operation in DDCMS #28933
  • File DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc modified in PR(s): Fix string operation in DDCMS #28933
  • File Geometry/HcalAlgo/plugins/dd4hep/DDHCalAngular.cc modified in PR(s): Fix string operation in DDCMS #28933
  • File Geometry/HcalAlgo/plugins/dd4hep/DDHCalTestBeamAlgo.cc modified in PR(s): Fix string operation in DDCMS #28933

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/HGCalCommonData
Geometry/HcalAlgo
Geometry/MuonCommonData
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @VinInn, @ptcox, @ebrondol, @ghugo83, @venturia this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5531
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4643/console Started: 2020/02/13 12:15

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

@kpedro88 any objection here? we need this one in so that we can go ahead with root updates (which are failing due to this change).

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5531
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4691/console Started: 2020/02/17 10:03

[cmsbuild]

-1

Tested at: 49c5a1e

CMSSW: CMSSW_11_1_ROOT6_X_2020-02-16-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d521ac/4691/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

@@@@ Running edmWriteConfigs for DDMTDLinear
--- Registered EDM Plugin: DDMTDLinear
Entering library rule at src/Geometry/MTDCommonData/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-16-2300/src/Geometry/MTDCommonData/test/DD4hep_TestMTDPosition.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-16-2300/src/Geometry/MTDCommonData/test/DD4hep_TestMTDPosition.cc: In lambda function:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_ROOT6_X_2020-02-16-2300/src/Geometry/MTDCommonData/test/DD4hep_TestMTDPosition.cc:163:25: error: no match for 'operator+' (operand types are 'const std::basic_string_view' and 'const char [2]')
         dump << t.first + "[" + t.second + "]/";
                 ~~~~~~~~^~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.21.01-d521ac/include/TCollection.h:29,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.21.01-d521ac/include/TSeqCollection.h:25,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.21.01-d521ac/include/TList.h:25,


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5531

[ianna]

There must have been some other recent PRs merged which require similar update.

[ianna]

Please, use #28985 which fixes the issue