HCALDQM: Fix ngHO crate-FED mapping (master)

[DryRun]

PR description:

This PR fixes the ngHO crate-FED mapping implemented in #28484. The mapping changed a bit since that PR, so HCAL is crashing the DQM playback again. There was some further work done, and crate 38 ended up being used, instead of 33. See that thread for more info on the expected changes.

This probably has cropped up a few times now, and might happen again in the future. We plan to move away from the hard-coded crate-FED map. A couple ideas:

1. Change from FED to something like RBX. HCAL ops doesn't like FED anyways, since it doesn't correspond to anything physical and is subject to change in the future (depending on the zero-suppression strategy at higher radiation damage, HCAL may move to 3 FEDs / crate).
2. Make FED available through conditions. Seems like a lot of work just to have FED on a plot axis.

PR validation:

Fixes the crash in playback. Passed runTheMatrix.py -l limited -i all --ibeos without error.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28952/13768

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28952/13768/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28952/13768/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28952/13769

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28952/13769/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28952/13769/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28952/13770

• This PR adds an extra 20KB to repository

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9bfc/4651/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694005
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693658
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -5.037 KiB( 33 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -0.219 KiB Hcal/DigiTask
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1
Changes expected due to new crate numbering

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #28963
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4696/console Started: 2020/02/17 11:10

[cmsbuild]

+1
Tested at: 0bb0bfd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a1a60/4696/summary.html
CMSSW: CMSSW_11_1_X_2020-02-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a1a60/4696/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694005
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693658
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1
Tested in Online DQM playback