Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM: Re-add harvesting test tools. #28986

Merged
merged 1 commit into from Feb 26, 2020

Conversation

schneiml
Copy link
Contributor

PR description:

These got accidentally deleted in the big DQM test cleanup (#28612), originally added in #28002.

The files are not used for any automated tests (primarily because we don't have any data reliably available), but can be useful to debug issues on real data. Downloading the DQMIO files before running the job should no longer be required (the input source now supports opening remote files), but it still helps to remove some unknowns from the test setup.

PR validation:

No changes to existing workflows. dqmiofilecopy.py still works to download DQMIO files when supplied with a dataset currently on disk.

These got deleted in the big DQM test cleanup (cms-sw#28612).

The files are not used for any automated tests, but can be useful to debug issues on real data.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28986/13818

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

DQMServices/Components

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4728/console Started: 2020/02/18 12:10

@cmsbuild
Copy link
Contributor

+1
Tested at: d9cfd19
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ed440/4728/summary.html
CMSSW: CMSSW_11_1_X_2020-02-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ed440/4728/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2694086
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2693766
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

@andrius-k @jfernan2 @kmaeshima @fioriNTU @schneiml
do you have any comments on this?

@schneiml
Copy link
Contributor Author

+1

Looks still good to me, and used to be in CMSSW before.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 41011bb into cms-sw:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants