New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM: Re-add harvesting test tools. #28986
Conversation
These got deleted in the big DQM test cleanup (cms-sw#28612). The files are not used for any automated tests, but can be useful to debug issues on real data.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28986/13818
|
A new Pull Request was created by @schneiml (Marcel Schneider) for master. It involves the following packages: DQMServices/Components @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@andrius-k @jfernan2 @kmaeshima @fioriNTU @schneiml |
+1 Looks still good to me, and used to be in CMSSW before. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
These got accidentally deleted in the big DQM test cleanup (#28612), originally added in #28002.
The files are not used for any automated tests (primarily because we don't have any data reliably available), but can be useful to debug issues on real data. Downloading the DQMIO files before running the job should no longer be required (the input source now supports opening remote files), but it still helps to remove some unknowns from the test setup.
PR validation:
No changes to existing workflows.
dqmiofilecopy.py
still works to download DQMIO files when supplied with a dataset currently on disk.