New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing includes and remove override identifier for non-virtual functions for CondFormats #29040
Conversation
…entifier for non-virtual functions
@oshadura, CMSSW_11_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29040/13906
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29040/13907
|
A new Pull Request was created by @oshadura (Oksana Shadura) for master. It involves the following packages: CondFormats/EcalObjects @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
bf09ad0
to
1aa75ab
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29040/13908
|
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This PR is part of #15248 |
hi @ggovi, all - any other comments on the small changes proposed? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add missing includes for CondFormats libraries and remove override identifier for non-virtual functions.
CC: @davidlange6 @vgvassilev
Tested locally with CXXMODULES IBs and these fixes allowed to enable 29 C++ modules (cms-sw/cmsdist#5600).