Enable Condformats C++ modules #5600

oshadura · 2020-02-25T16:47:42Z

The initial CXXModules.mk.files was changed to make easier grouping of modules and related to them hacks to enable modules.

This PR should be tested and merged only after cms-sw/cmssw#29040

CC: @davidlange6 @vgvassilev

cmsbuild · 2020-02-25T16:50:12Z

A new Pull Request was created by @oshadura (Oksana Shadura) for branch IB/CMSSW_11_1_X/rootmodule.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

vgvassilev · 2020-02-28T14:09:15Z

Part of cms-sw/cmssw#15248

mrodozov · 2020-02-28T14:18:06Z

do we need this in the IB, i.e. should I merge it and then restart the IB ?
Ah ok I see the comment above, its clear now

davidlange6 · 2020-02-28T14:30:28Z

The cmssw pr is not merged yet.. On Feb 28, 2020, at 9:18 AM, Mircho Rodozov <notifications@github.com<mailto:notifications@github.com>> wrote: do we need this in the IB, i.e. should I merge it and then restart the IB ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#5600?email_source=notifications&email_token=ABGPFQ5EI2EHHBXQU4G4WPDRFEMJ7A5CNFSM4K3OAXZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENIVHXQ#issuecomment-592532446>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ3LE5C5BNG47TN4TW3RFEMJ7ANCNFSM4K3OAXZA>.

mrodozov · 2020-02-28T14:31:24Z

right sry for the spam

cmsbuild · 2020-03-03T16:46:35Z

Pull request #5600 was updated.

smuzaffar · 2020-03-03T19:31:53Z

test parameters

full_cmssw = true

smuzaffar · 2020-03-03T19:32:02Z

please test

cmsbuild · 2020-03-03T19:32:11Z

The tests are being triggered in jenkins.
Test Parameters:

BUILD_FULL_CMSSW = true
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4980/console Started: 2020/03/03 20:34

cmsbuild · 2020-03-04T00:15:41Z

-1

Tested at: 0ef7d2d

CMSSW: CMSSW_11_1_CXXMODULE_X_2020-03-02-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f78e54/4980/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found compilation error when building:

>> Compiling  tmp/slc7_amd64_gcc820/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/Serialization.cc 
>> Building LCG reflex dict from header file tmp/slc7_amd64_gcc820/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/CondFormatsLuminosity_xr.h
In file included from input_line_12:42:
In file included from ./tmp/slc7_amd64_gcc820/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/CondFormatsLuminosity_xr.h:1:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-03-02-2300/src/CondFormats/Luminosity/src/headers.h:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-03-02-2300/src/CondFormats/Luminosity/interface/LumiCorrections.h:42:3: error: C++ requires a type specifier for all declarations
  COND_SERIALIZABLE;
  ^
Error: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.19.01-f78e54/bin/rootcling: compilation failure (tmp/slc7_amd64_gcc820/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/libCondFormatsLuminosityda91d874a8_dictUmbrella.h)
rootcling: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/lcg/root/6.19.01-f78e54/root-6.19.01/interpreter/cling/lib/Interpreter/IncrementalParser.cpp:407: cling::IncrementalParser::~IncrementalParser(): Assertion `(T->getState() == Transaction::kCommitted || T->getState() == Transaction::kRolledBackWithErrors || T->getState() == Transaction::kNumStates || T->getState() == Transaction::kRolledBack) && "Not committed?"' failed.
/bin/sh: line 1: 21994 Aborted                 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.19.01-f78e54/bin/rootcling -reflex -f tmp/slc7_amd64_gcc820/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/CondFormatsLuminosity_xr.cc -s tmp/slc7_amd64_gcc820/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/libCondFormatsLuminosity.so -cxxmodule -failOnWarnings -DCMS_DICT_IMPL -D_REENTRANT -DGNUSOURCE -D__STRICT_ANSI__ -moduleMapFile=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-03-02-2300/include/slc7_amd64_gcc820/cxxmodules/module.modulemap -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=80301 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DCMSSW_GIT_HASH='"CMSSW_11_1_CXXMODULE_X_2020-03-02-2300"' -DPROJECT_NAME='"CMSSW"' -DPROJECT_VERSION='"CMSSW_11_1_CXXMODULE_X_2020-03-02-2300"' -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-03-02-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/lcg/root/6.19.01-f78e54/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/pcre/8.37-pafccj/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/boost/1.67.0-pafccj/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/bz2lib/1.0.6-pafccj/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/libuuid/2.34/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/tbb/2019_U9/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/xz/5.2.4/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/zlib-x86_64/1.2.11-pafccj/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/md5/1.0.0-pafccj/include -DCMSSW_REFLEX_DICT -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-03-02-2300/src/CondFormats/Luminosity/src tmp/slc7_amd64_gcc820/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/CondFormatsLuminosity_xr.h src/CondFormats/Luminosity/src/classes_def.xml

cmsbuild · 2020-03-04T00:15:43Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

oshadura · 2020-03-04T12:34:37Z

It is missing one more PR cms-sw/cmssw#29086 (sorry for late notice)

mrodozov · 2020-03-04T12:50:55Z

test parameters:

full_cmssw = true
pull_requests = Add header guards for DYTThrObject.h and Serializable.h cmssw#29086

mrodozov · 2020-03-04T12:51:14Z

please test

cmsbuild · 2020-03-04T12:51:40Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29086
Test Parameters:

BUILD_FULL_CMSSW = true
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4989/console Started: 2020/03/04 13:58

cmsbuild · 2020-03-04T19:12:56Z

-1

Tested at: 0ef7d2d

CMSSW: CMSSW_11_1_CXXMODULE_X_2020-03-03-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f10a6f/4989/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-03-03-2300/src/Mixing/Base/src/PileUp.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-03-03-2300/src/Mixing/Base/src/BMixingModule.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-03-03-2300/src/Mixing/Base/src/SecondaryEventProvider.cc 
>> Building shared library tmp/slc7_amd64_gcc820/src/Mixing/Base/src/MixingBase/libMixingBase.so
/cvmfs/cms-ib.cern.ch/nweek-02618/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCondFormatsRunInfo
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc820/src/Mixing/Base/src/MixingBase/libMixingBase.so] Error 1
Leaving library rule at Mixing/Base
>> Leaving Package Mixing/Base
>> Package Mixing/Base built
>> Leaving Package PhysicsTools/CandAlgos

cmsbuild · 2020-03-04T19:13:01Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

davidlange6 · 2020-03-18T09:48:27Z

finally the CMSSW PR has been merged (days of difficult review per line of change...)

oshadura changed the title ~~Enable Condformats~~ Enable Condformats C++ modules Feb 25, 2020

oshadura requested a review from davidlange6 February 25, 2020 16:47

oshadura mentioned this pull request Feb 25, 2020

Add missing includes and remove override identifier for non-virtual functions for CondFormats cms-sw/cmssw#29040

Merged

cmsbuild added comparison-pending externals-pending orp-pending pending-signatures tests-pending labels Feb 25, 2020

Enable 29 CondFormats modules for CXXModules IBs

0ef7d2d

oshadura force-pushed the enable-condformats branch from e3d967e to 0ef7d2d Compare March 3, 2020 16:46

oshadura mentioned this pull request Mar 3, 2020

Add header guards for DYTThrObject.h and Serializable.h cms-sw/cmssw#29086

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 3, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Mar 4, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Mar 4, 2020

cmsbuild added requires-external tests-started and removed tests-pending labels Mar 4, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Mar 4, 2020

davidlange6 merged commit d43baa1 into cms-sw:IB/CMSSW_11_1_X/rootmodule Mar 18, 2020

davidlange6 mentioned this pull request Mar 23, 2020

Revert "Enable Condformats C++ modules" #5691

Merged

cmsbuild mentioned this pull request May 17, 2022

[CXXMODULE] Update root module to follow root master branch #7874

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Condformats C++ modules #5600

Enable Condformats C++ modules #5600

oshadura commented Feb 25, 2020 •

edited

cmsbuild commented Feb 25, 2020

vgvassilev commented Feb 28, 2020

mrodozov commented Feb 28, 2020 •

edited

davidlange6 commented Feb 28, 2020 via email

mrodozov commented Feb 28, 2020

cmsbuild commented Mar 3, 2020

smuzaffar commented Mar 3, 2020

smuzaffar commented Mar 3, 2020

cmsbuild commented Mar 3, 2020 •

edited

cmsbuild commented Mar 4, 2020

cmsbuild commented Mar 4, 2020

oshadura commented Mar 4, 2020 •

edited

mrodozov commented Mar 4, 2020

mrodozov commented Mar 4, 2020

cmsbuild commented Mar 4, 2020 •

edited

cmsbuild commented Mar 4, 2020

cmsbuild commented Mar 4, 2020

davidlange6 commented Mar 18, 2020

Enable Condformats C++ modules #5600

Enable Condformats C++ modules #5600

Conversation

oshadura commented Feb 25, 2020 • edited

cmsbuild commented Feb 25, 2020

vgvassilev commented Feb 28, 2020

mrodozov commented Feb 28, 2020 • edited

davidlange6 commented Feb 28, 2020 via email

mrodozov commented Feb 28, 2020

cmsbuild commented Mar 3, 2020

smuzaffar commented Mar 3, 2020

smuzaffar commented Mar 3, 2020

cmsbuild commented Mar 3, 2020 • edited

cmsbuild commented Mar 4, 2020

cmsbuild commented Mar 4, 2020

oshadura commented Mar 4, 2020 • edited

mrodozov commented Mar 4, 2020

mrodozov commented Mar 4, 2020

cmsbuild commented Mar 4, 2020 • edited

cmsbuild commented Mar 4, 2020

cmsbuild commented Mar 4, 2020

davidlange6 commented Mar 18, 2020

oshadura commented Feb 25, 2020 •

edited

mrodozov commented Feb 28, 2020 •

edited

cmsbuild commented Mar 3, 2020 •

edited

oshadura commented Mar 4, 2020 •

edited

cmsbuild commented Mar 4, 2020 •

edited