GEM validation package update

[dildick]

PR description:

This PR is a big update of the GEM validation packages. Among others it updates old plots, removes redundant ones, introduces validation plots for GEM pad clusters and puts plugins in the correct directories.

PR validation:

This PR was tested with workflow 22021.0.

Validation plots can be found here:

• https://indico.cern.ch/event/889918/contributions/3752954/attachments/1989496/3316341/GEM_200218_Validation-SW.pdf
• https://indico.cern.ch/event/891703/contributions/3761082/attachments/1993812/3325504/200226_GEM_Validation-SW.pdf

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@jshlee @seungjin-yang

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29042/13910

• This PR adds an extra 116KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

Validation/MuonGEMDigis
Validation/MuonGEMHits
Validation/MuonGEMRecHits
Validation/MuonHits

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@jshlee this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4880/console Started: 2020/02/26 08:42

[seungjin-yang]

Additional PR description

1. Correct the definition of pull on the local position of GEMRecHit.
   Official cmssw use GEMRecHit::localPositionErrorr().xx() as the denominator.
   This PR use sqrt(GEMRecHit::localPositionErrorr().xx())

2. Change the definition of efficiency plots from the fraction of the simulated muon tracks that are associated with GEMDigi or GEMRecHit to the fraction of the simulated muon hits (PSimHIt) with an associated GEMDigi or GEMRecHit.

[cmsbuild]

+1
Tested at: 616b8a1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b69bee/4880/summary.html
CMSSW: CMSSW_11_1_X_2020-02-25-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b69bee/4880/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b69bee/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b69bee/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b69bee/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b69bee/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b69bee/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b69bee/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2678312
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2677991
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 559381.842 KiB( 33 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 4620.737 KiB MuonGEMDigisV/GEMDigisTask
• DQMHistoSizes: changed ( 10024.0,... ): 4221.187 KiB MuonGEMRecHitsV/GEMRecHitsTask
• DQMHistoSizes: changed ( 10024.0,... ): 4187.169 KiB MuonGEMHitsV/GEMHitsTask
• DQMHistoSizes: changed ( 11634.0,... ): 30986.980 KiB MuonGEMDigisV/GEMDigisTask
• DQMHistoSizes: changed ( 11634.0,... ): 8410.644 KiB MuonGEMRecHitsV/GEMRecHitsTask
• DQMHistoSizes: changed ( 11634.0,... ): 8264.313 KiB MuonGEMHitsV/GEMHitsTask
• DQMHistoSizes: changed ( 20034.0,... ): 63369.808 KiB MuonGEMDigisV/GEMDigisTask
• DQMHistoSizes: changed ( 20034.0,... ): 16690.095 KiB MuonGEMRecHitsV/GEMRecHitsTask
• DQMHistoSizes: changed ( 20034.0,... ): 16410.949 KiB MuonGEMHitsV/GEMHitsTask
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

please test workflow 22021.0

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 22021.0
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4935/console Started: 2020/02/29 10:47

[cmsbuild]

-1

Tested at: 6142398

CMSSW: CMSSW_11_1_X_2020-02-28-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b69bee/4935/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[silviodonato]

@dildick do you have a PR to add WF 22021.0? I cannot find it with runTheMatrix.py -n

[dildick]

@seungjin-yang Could you please comment? WF 22021.0 does not appear to exist.

[seungjin-yang]

@silviodonato I used runTheMatrix.py -w upgrade -l 22021.0 The geometry used is GeometryExtended2026D46.

[silviodonato]

right, we cannot test wf in -w upgrade (see #28773 (comment))

[silviodonato]

+1

[silviodonato]

merge