HCAL: TDC simulation fix

[lwang046]

PR description:

This PR is a fix to the Hcal DQM issue in #29076 which was revealed by #29035 after change Hcal frame size from 8 to 10. The previous code was hardcoded for 8 TS case in run2. The change adjust the sample size automatically.

[cmsbuild]

@lwang046, CMSSW_11_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29083/13971

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @lwang046 for master.

It involves the following packages:

SimCalorimetry/HcalSimAlgos

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@mariadalfonso this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4973/console Started: 2020/03/03 17:23

[cmsbuild]

+1
Tested at: e000458
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a73b9a/4973/summary.html
CMSSW: CMSSW_11_1_X_2020-03-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a73b9a/4973/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680373
• DQMHistoTests: Total failures: 40
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680014
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

it would be nice to have this merged soon, assuming this actually fixes the random differences in DQM comparisons

[abdoulline]

@civanch @silviodonato may we get it merged, please?

[silviodonato]

@civanch @mdhildreth could you have a look to this PR?

[silviodonato]

merge
@civanch @mdhildreth please let me know if you have any comment