Make L1Comparator a global module

[Dr15Jones]

PR description:

This module is run in release validation and prohibits use of concurrent LuminosityBlocks.

PR validation:

The code compiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

prompted by #25090

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29103/14003

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/L1Trigger
L1Trigger/HardwareValidation

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5000/console Started: 2020/03/04 23:42

[cmsbuild]

+1
Tested at: 30ac87b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27ec2c/5000/summary.html
CMSSW: CMSSW_11_1_X_2020-03-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27ec2c/5000/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2680577
• DQMHistoTests: Total failures: 43
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2680215
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[Dr15Jones]

ping

[silviodonato]

This is a technical PR. @benkrikler @rekovic Do you have any objections?

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1