Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BasicGenValidation_cff.py #29146

Merged
merged 1 commit into from Mar 9, 2020
Merged

Update BasicGenValidation_cff.py #29146

merged 1 commit into from Mar 9, 2020

Conversation

menglu21
Copy link
Contributor

@menglu21 menglu21 commented Mar 8, 2020

add sequence for higgs/ttbar separate validation

PR description:

The changes made are for the sample validation using McM, people can now choose higgs/dy/top/w/qcd process to be validated. The top/higgs parts are added by imitating the existing dy/qcd... In the output rootfile, there will be additional branch for VALIDATIONS. The slides are https://indico.cern.ch/event/878706/contributions/3761830/attachments/1993587/3324981/GENvalidation.pdf

PR validation:

Validation done by following steps:

  1. cmsrel CMSSW_7_1_45_patch3
  2. cd src & cmsenv
  3. git add-cmspkg Validation/EventGenerator & modify the BasicGenValidation_cff.py
  4. cd ../../
  5. ./aa
    where aa is https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_test/SMP-RunIISummer15wmLHEGS-00378, the request is set to run 'higgs' content validation.

The output is:
`...
LHE,GEN,SIM,VALIDATION:genvalid_higgs
Step: LHE Spec:
Loading lhe fragment from Configuration.GenProduction.SMP-RunIISummer15wmLHEGS-00378-fragment
Step: GEN Spec:
Loading generator fragment from Configuration.GenProduction.SMP-RunIISummer15wmLHEGS-00378-fragment
Step: SIM Spec:
Step: VALIDATION Spec: ['genvalid_higgs']
genvalid_higgs in preparing validation

customising the process with addMonitoring from Configuration/DataProcessing/Utils
customising the process with customisePostLS1 from SLHCUpgradeSimulations/Configuration/postLS1Customs
customising the process with setCrossingFrameOn from SimGeneral/MixingModule/fullMixCustomize_cff
Config file SMP-RunIISummer15wmLHEGS-00378_1_cfg.py created
==> using COND/Services/RelationalAuthenticationService for auth, sys 1
==> using COND/Services/RelationalAuthenticationService for auth, sys 1


     Running Generic Tarball/Gridpack     

gridpack tarball path = /cvmfs/cms.cern.ch/phys_generator/gridpacks/slc6_amd64_gcc481/13TeV/madgraph/V5_2.2.2/dyellell012j_5f_NLO_FXFX_M100to200/v1/dyellell012j_5f_NLO_FXFX_M100to200_tarball.tar.xz
%MSG-MG5 number of events requested = 98
%MSG-MG5 random seed used for the run = 52
%MSG-MG5 thread count requested = 1
%MSG-MG5 residual/optional arguments =
...`

From the log, the genvalidation_higgs is compiled successfully, and a rootfile is obtained eventually.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

add sequence for higgs/ttbar separate validation
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29146/14077

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2020

A new Pull Request was created by @menglu21 (Meng_Lu) for master.

It involves the following packages:

Validation/EventGenerator

@SiewYan, @andrius-k, @mkirsano, @kmaeshima, @schneiml, @efeyazgan, @cmsbuild, @jfernan2, @agrohsje, @fioriNTU, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 8, 2020

@menglu21 have you performed some test/validation over this change? If so, can you please post your results along with some description in the PR header as requested? Thanks

@menglu21
Copy link
Contributor Author

menglu21 commented Mar 8, 2020

@menglu21 have you performed some test/validation over this change? If so, can you please post your results along with some description in the PR header as requested? Thanks

Hi, i updated the PR header with the description, validation step and results, the log is not full but only with the important parts.

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5060/console Started: 2020/03/08 14:59

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2020

+1
Tested at: ae7d51c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b77489/5060/summary.html
CMSSW: CMSSW_11_1_X_2020-03-08-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b77489/5060/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 40
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680218
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 9, 2020

+1

@qliphy
Copy link
Contributor

qliphy commented Mar 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

@menglu21
Does this PR should be backported to 10_6 at least?

@qliphy @pgunnell

@pgunnell
Copy link
Contributor

yes, we provided @menglu21 with the list of relevant releases for production

@menglu21
Copy link
Contributor Author

Hi all,
Sorry for the delay, i'll do the backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants