Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of pythia 8 EGun code from CMSSW_11_1 to CMSSW_9_2_8 #29149

Closed
wants to merge 1 commit into from
Closed

Backport of pythia 8 EGun code from CMSSW_11_1 to CMSSW_9_2_8 #29149

wants to merge 1 commit into from

Conversation

pasmuss
Copy link

@pasmuss pasmuss commented Mar 9, 2020

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport for PR #29000 to CMSSW_9_2_8 for MC production. #29000 already approved and merged.

PR description (from original request):

Changes for proper treatment of color (conservation and codes):

  • Increasing color index after generating one particle (anti particle obtains the same color, just on the anticolor column)
  • Adding a check that if only colored particles are generated, the AddAntiParticle option is used to make sure that all colors are balanced
  • Only affecting pythia8 EGun

PR validation (from original request):

Ran some tests locally with a core CMSSW script:

  • not set AddAntiParticle at all (does not start, option must be set)
  • set option to False (runs but does not generate anything and throws errors)
  • set option to True (as expected: anti particle gets same anti color as particle gets color, index is not the same for two different particles)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

A new Pull Request was created by @pasmuss for CMSSW_9_2_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Mar 9, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

-1
Tested at: UNKNOWN
I was not able to find a release to test this PR. See the Jenkins logs for more details.

@qliphy
Copy link
Contributor

qliphy commented Mar 9, 2020

@smuzaffar @mrodozov Can you have a look at above message? Thanks!

@smuzaffar
Copy link
Contributor

@silviodonato @qliphy , we are not building IBs for 92X release cycle since May 2018. If we really need to include this in 9.2.X then we have to re-enable 92X IBs first.

@qliphy
Copy link
Contributor

qliphy commented Mar 9, 2020

@pasmuss Do you wants to backport to 9_2_X or 9_3_X?

@pasmuss
Copy link
Author

pasmuss commented Mar 9, 2020

MC Request was created in Summer17GS (9_2_8). Can most likely go in Fall17 (9_3_17), if that is easier. Do I need to recreate this pull request then?

@mrodozov
Copy link
Contributor

mrodozov commented Mar 9, 2020

We have 9.3 IB . Please recreate it with base branch https://github.com/cms-sw/cmssw/tree/CMSSW_9_3_X . Changing the base branch here will bring many differences

@pasmuss
Copy link
Author

pasmuss commented Mar 9, 2020

Created new PR to CMSSW_9_3_X, #29153

@pasmuss pasmuss closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants