Fireworks: Auto detect geometry version from global tag.

[alja]

With this PR cmsShow reads global tag from data file, guess geometry version from it and load that geometry if necessary.

[cmsbuild]

@alja, CMSSW_11_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[alja]

@smuzaffar @ianna
-1
This PR depends on on changes in https://github.com/cms-data/Fireworks-Geometry

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29169/14137

• This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29169/14137/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29169/14137/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[silviodonato]

@smuzaffar @ianna
-1
This PR depends on on changes in https://github.com/cms-data/Fireworks-Geometry

I take this as a "please close this PR". If I am wrong, please let me know and I will reopen the PR

[smuzaffar]

The data files is too big to put it in github repository. @alja , can you please share the file via your public AFS area? We can copy this file to cmssdt03 server and include it from there.

[alja]

@smuzaffar
I have put updated Fireworks-Geomtery directory here /afs/cern.ch/user/a/amraktad/public/Fireworks-Geometry
Let me know if I can help any further.

[alja]

@smuzaffar
I have run code formatting and committed the change to same branch https://github.com/alja/cmssw/tree/geo-gt, but I will wait to reopen this PR after Fireworks-Geometry update.

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

@alja , we need some changes for the data external to pick extra files, I will do those and will open a PR for data external.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29169/14476

• This PR adds an extra 68KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29169/14476/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29169/14476/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/Fireworks-Geometry#10,cms-sw/cmsdist#5713
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5509/console Started: 2020/04/02 19:21

[cmsbuild]

+1
Tested at: e34e581
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba373d/5509/summary.html
CMSSW: CMSSW_11_1_X_2020-04-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5713
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5537/console Started: 2020/04/05 00:08

[cmsbuild]

+1
Tested at: e34e581
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eaf24d/5537/summary.html
CMSSW: CMSSW_11_1_X_2020-04-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

[silviodonato]

+1