Clean residual dependency of SimG4Core/Forward on DetectorDescription

[fabiocos]

PR description:

This PR follows the comments in #29213 about removing completely an apparently fake dependence of SimG4Core/Forward on DetectorDescription , namely in the ZDC-related classes.

PR validation:

Code compiles, test wfs 11634 and 23234 both run smoothly.

[cmsbuild]

The code-checks are being triggered in jenkins.

[fabiocos]

@bsunanda FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29223/14245

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

SimG4CMS/Forward

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5247/console Started: 2020/03/18 11:45

[cmsbuild]

+1
Tested at: 1ea6f0c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18101f/5247/summary.html
CMSSW: CMSSW_11_1_X_2020-03-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Minor improvements to MessageLogger #29220 @Dr15Jones: Minor improvements to MessageLogger
• Remove parameters of GsfElectronBaseProducer not used after #28429 #29157 @guitargeek: Remove parameters of GsfElectronBaseProducer not used after Phase out old pre-GED GsfElectron sequence #28429
• [DD4hep] DD Filtered View: Add Debug Print, RegExp Speed Up and Clean Up #29208 @ianna: [DD4hep] DD Filtered View: Add Debug Print, RegExp Speed Up and Clean Up
• MTD Sensitive Detector: make it independent on DDD #29213 @fabiocos: MTD Sensitive Detector: make it independent on DDD

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18101f/5247/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18101f/5247/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18101f/5247/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692437
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2692117
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1