Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for mxnet python interface #29243

Merged
merged 3 commits into from Mar 24, 2020
Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Mar 19, 2020

PR description:

Adds unit test for the mxnet python interface
Copied from here https://mxnet.apache.org/get_started/validate_mxnet#python
The test needs this changes:
cms-sw/cmsdist#5667

PR validation:

The test runs

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

b = a * 2 + 1
b.asnumpy()
numpy.array([[ 3., 3., 3.],
[ 3., 3., 3.]], dtype=numpy.float32)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand these last 2 lines. I think just copy pasted the example. These lines are generated by b.asnumpy()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand either until I finally read the text above it - it was a code so I took it as part of the example 😅

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29243/14281

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

PhysicsTools/MXNet

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@hqucms this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

I thought that was part of the example
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29243/14283

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #29243 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29243/14290

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #29243 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Mar 23, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5327/console Started: 2020/03/23 14:31

@cmsbuild
Copy link
Contributor

+1
Tested at: 0f39e07
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bac7c/5327/summary.html
CMSSW: CMSSW_11_1_X_2020-03-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bac7c/5327/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692493
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692141
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar smuzaffar changed the title Add test for mxnet python iface Add test for mxnet python interface Mar 23, 2020
@slava77
Copy link
Contributor

slava77 commented Mar 23, 2020

+1

for #29243 0f39e07

  • unit test is somewhat simple, but should serve the purpose
  • jenkins tests unit test log shows that the test passed OK

@silviodonato
Copy link
Contributor

merge
@santocch this PR add a new simple unit test

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants