New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for mxnet python interface #29243
Conversation
The code-checks are being triggered in jenkins. |
b = a * 2 + 1 | ||
b.asnumpy() | ||
numpy.array([[ 3., 3., 3.], | ||
[ 3., 3., 3.]], dtype=numpy.float32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand these last 2 lines. I think just copy pasted the example. These lines are generated by b.asnumpy()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't understand either until I finally read the text above it - it was a code so I took it as part of the example 😅
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29243/14281
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: PhysicsTools/MXNet @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
I thought that was part of the example
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29243/14283
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29243/14290
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Adds unit test for the mxnet python interface
Copied from here https://mxnet.apache.org/get_started/validate_mxnet#python
The test needs this changes:
cms-sw/cmsdist#5667
PR validation:
The test runs