Minor enhancements to special geometry comparison test

[cvuosalo]

runDDDvsDBGeometryValidation.sh is a special test to be run by experts to compare the geometry in a local database and the Conditions database. One test in the script is to compare the concatenated geometry XML files in each database. These files may actually differ, or they may only appear to differ because of different ordering of some of the content of the files.

I added a two more tests to the script to try to help the expert determine whether there are real differences in the two geometry XML files or whether the apparent differences are due to minor re-ordering. The overall problem of definitively determining whether two big XML files are functionally identical even if their parts are in different orders is still not solved, though the enhancements in this PR are a step in that direction. Maybe this issue can be fully resolved in a later PR.

One file in this PR is unrelated to the others. splitExtended2021Database.sh is used for creating payloads. The DB group requested that I update the command used in the script from
conddb_import, which is intended to be decommissioned, to conddb.

PR validation:

The scripts run and produce informative output. They have no effect on production workflows or unit tests.

splitExtended2021Database.sh continues to work and create payloads. With the change in command, I noticed that the comment field in the payload changed. For example, the old conddb_import created the following payload. Note the Description field.

Name                    TimeType  ObjectType     Synchronisation  EndOfValidity  Insertion_time              Description                                                             
----------------------  --------  -------------  ---------------  -------------  --------------------------  ---------------------------------------------------------------------   
TKRECO_Geometry_111YV1  Run       PGeometricDet  any              -1             2020-03-02 17:49:31.613191  Created copying tag TKRECO_Geometry_111YV1 from sqlite_file:myfile.db   

The new conddb created almost the same payload:

Name                    TimeType  ObjectType     Synchronisation  EndOfValidity  Insertion_time              Description   
----------------------  --------  -------------  ---------------  -------------  --------------------------  -----------   
TKRECO_Geometry_111YV1  Run       PGeometricDet  any              -1             2020-03-21 02:58:08.136170  New Tag       

Note that Description field is different. I assume this difference is harmless.

No backport is needed for this PR.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29278/14333

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

CondTools/Geometry
Validation/Geometry

@andrius-k, @Dr15Jones, @makortel, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch, @ggovi can you please review it and eventually sign? Thanks.
@vargasa, @rovere, @apsallid, @lecriste, @mmusich, @rishabhCMS, @rbartek this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

@ggovi Please check splitExtended2021Database.sh and let me know if I have used the correct arguments for the new command. They seem to work correctly as far as I could tell.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5339/console Started: 2020/03/24 03:19

[cmsbuild]

+1
Tested at: 9df67a7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7475e0/5339/summary.html
CMSSW: CMSSW_11_1_X_2020-03-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7475e0/5339/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692493
• DQMHistoTests: Total failures: 70
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2692104
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[ggovi]

+1

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1