Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove puppi multipliticies from JME nano #29296

Merged
merged 1 commit into from Mar 26, 2020

Conversation

ahinzmann
Copy link
Contributor

PR description:

Fix issue reported in #28936

PR validation:

runTheMatrix -l 25202.01

no backports.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ahinzmann ahinzmann mentioned this pull request Mar 25, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29296/14361

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Mar 25, 2020

@cmsbuild please test workflow 25202.01

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 25, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 9daf0a2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddcc6d/5371/summary.html
CMSSW: CMSSW_11_1_X_2020-03-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Mar 25, 2020

@peruzzim @fgolf
please check this at somewhat elevated priority
Thank you.

@peruzzim
Copy link
Contributor

only affects the JME custom workflow and JME is ok with it: #28936 (comment)
so I expect that it's ok to merge, will add signature as soon as tests succeed

@peruzzim peruzzim mentioned this pull request Mar 25, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddcc6d/5371/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ddcc6d/25202.01_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691768
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@peruzzim
Copy link
Contributor

+xpog

@slava77
Copy link
Contributor

slava77 commented Mar 25, 2020

Reco comparison results: 2 differences found in the comparisons

also, the special JME nano 25202.01 passed OK

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3a3f78b into cms-sw:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants