Add EventsPerLumi for relvals workflows and prod-like concurrentLS relvals #29318

srimanob · 2020-03-27T07:16:09Z

PR description:

This PR is to add an option to set EventsPerLumi in relvals. Normally, GEN relvals will set EventsPerLumi = EventsPerJobs. Setting can be done in 2 ways:

propagate from process.source.numberEventsInLuminosityBlock in relvals workflow, or
parameter of runTheMatrix, runTheMatrix.py --numberEventsInLuminosityBlock (overwrite "1." if both options exist)

In addition, 2 additional relvals (1302.181 and 1304.181) are added. They are prod-like 2018 production with concurrentLumis enable.

RelVals: Link

srimanob_RVCMSSW_11_1_0_pre4ProdTTbar_13UP18ml__ml_PHATTEST_200326_215358_6428 (concurrentLumis enable with new EventsPerLumi setting )
srimanob_RVCMSSW_11_1_0_pre4ProdTTbar_13UP18__ml_PHATTEST_200326_215402_5324 (normal relvals workflows, with new EventsPerLumi setting )

PR validation:

runTheMatrix.py --what standard -l 1302.18,1304.18,1302.181,1304.181 -t 4 --wm init
==> only concurrentLumis workflows have EventsPerLumi = 5 (as set in cmsDriver)

runTheMatrix.py --what standard -l 1302.18,1304.18,1302.181,1304.181 --numberEventsInLuminosityBlock 20 -t 4 --wm init
==> All workflows have EventsPerLumi = 20

if this PR is a backport please specify the original PR and why you need to backport that PR:

…concurrentlumi relvals

cmsbuild · 2020-03-27T07:16:34Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-27T07:18:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-27T07:23:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29318/14396

This PR adds an extra 64KB to repository

cmsbuild · 2020-03-27T07:24:17Z

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

srimanob · 2020-03-27T08:55:29Z

@makortel @Dr15Jones @silviodonato @fabiocos @chayanit
Do you think it's useful if we try to cross LS in every GEN-related relvals, not only in IB? I don't see the cons yet.

Dr15Jones · 2020-03-27T12:26:15Z

Doing more comprehensive testing of jobs with multiple LuminosityBlocks makes sense to me. The down side, is without concurrent lumis (and even with but with module's that inhibit efficient use of concurrent lumis) the multi-thread efficiency of the jobs will descrease. Say we use 4 threads and 5 events per lumi. So on average each thread only processes 1 event and then has to wait for all other threads to finish (because of synchronization on the lumi boundary).

srimanob · 2020-03-27T18:35:21Z

Hi @Dr15Jones
Thanks for the comment. Normally, relvals run 50 events per job, we do like 10 events/lumi or 25/lumi by default. For IB, it will pick up from cmsDriver directly, 5 events/lumi.

chayanit · 2020-03-30T15:47:46Z

please test workflow 1302.18,1304.18,1302.181,1304.181

cmsbuild · 2020-03-30T15:48:06Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 1302.181,1304.18,1302.18,1304.181
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5438/console Started: 2020/03/30 17:48

Configuration/PyReleaseValidation/python/MatrixInjector.py

cmsbuild · 2020-03-30T17:00:57Z

+1
Tested at: 450129a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d74d4/5438/summary.html
CMSSW: CMSSW_11_1_X_2020-03-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-03-30T17:00:59Z

Comparison job queued.

cmsbuild · 2020-03-30T18:28:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d74d4/5438/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d74d4/1302.181_ProdTTbar_13UP18ml+ProdTTbar_13UP18ml+DIGIUP18PROD1ml+RECOPRODUP18ml+MINIAODMCUP18ml+NANOPRODUP18ml
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d74d4/1302.18_ProdTTbar_13UP18+ProdTTbar_13UP18+DIGIUP18PROD1+RECOPRODUP18+MINIAODMCUP18+NANOPRODUP18
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d74d4/1304.181_ProdZEE_13UP18ml+ProdZEE_13UP18ml+DIGIUP18PROD1ml+RECOPRODUP18ml+MINIAODMCUP18ml+NANOPRODUP18ml

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2692110
DQMHistoTests: Total failures: 36
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2691755
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

kpedro88 · 2020-04-02T16:07:17Z

test parameters
workflows = 1302.18,1304.18,1302.181,1304.181

kpedro88 · 2020-04-02T16:07:22Z

please test

cmsbuild · 2020-04-02T16:07:40Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 1302.18,1304.18,1302.181,1304.181
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5506/console Started: 2020/04/02 18:11

cmsbuild · 2020-04-02T18:03:50Z

+1
Tested at: 19d83f4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d74d4/5506/summary.html
CMSSW: CMSSW_11_1_X_2020-04-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-02T18:03:53Z

Comparison job queued.

cmsbuild · 2020-04-02T19:39:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d74d4/5506/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d74d4/1302.181_ProdTTbar_13UP18ml+ProdTTbar_13UP18ml+DIGIUP18PROD1ml+RECOPRODUP18ml+MINIAODMCUP18ml+NANOPRODUP18ml
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d74d4/1302.18_ProdTTbar_13UP18+ProdTTbar_13UP18+DIGIUP18PROD1+RECOPRODUP18+MINIAODMCUP18+NANOPRODUP18
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d74d4/1304.181_ProdZEE_13UP18ml+ProdZEE_13UP18ml+DIGIUP18PROD1ml+RECOPRODUP18ml+MINIAODMCUP18ml+NANOPRODUP18ml

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2692110
DQMHistoTests: Total failures: 38
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2691753
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

kpedro88 · 2020-04-03T13:31:28Z

+upgrade

silviodonato · 2020-04-06T10:09:01Z

Do you have comments @chayanit @pgunnell @wajidalikhan ?

chayanit · 2020-04-06T15:22:08Z

+1

cmsbuild · 2020-04-06T15:22:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-04-06T17:53:36Z

+1

Add option for EventsPerLumi for relvals workflows and new prod-like …

df6f0ac

…concurrentlumi relvals

cmsbuild added this to the CMSSW_11_1_X milestone Mar 27, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Mar 27, 2020

fix ProdZEE to be concurrentLumis workflows

450129a

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 27, 2020

cmsbuild added tests-started and removed tests-pending labels Mar 30, 2020

kpedro88 reviewed Mar 30, 2020

View reviewed changes

Configuration/PyReleaseValidation/python/MatrixInjector.py Outdated Show resolved Hide resolved

Configuration/PyReleaseValidation/python/MatrixInjector.py Outdated Show resolved Hide resolved

Configuration/PyReleaseValidation/python/MatrixInjector.py Outdated Show resolved Hide resolved

cmsbuild added tests-approved and removed tests-started labels Mar 30, 2020

cmsbuild removed the comparison-pending label Mar 30, 2020

cmsbuild added tests-pending and removed tests-started labels Apr 2, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 2, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 2, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 2, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Apr 3, 2020

cmsbuild mentioned this pull request Apr 4, 2020

Replace validationHarvestingNoHLT with validationHarvesting in HI workflows #29393

Merged

cmsbuild added fully-signed pdmv-approved and removed pdmv-pending pending-signatures labels Apr 6, 2020

cmsbuild added orp-approved and removed orp-pending labels Apr 6, 2020

cmsbuild merged commit 38cf3d1 into cms-sw:master Apr 6, 2020

jpata mentioned this pull request Jun 9, 2021

Track-gen matching passing through TrackingParticle #33774

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EventsPerLumi for relvals workflows and prod-like concurrentLS relvals #29318

Add EventsPerLumi for relvals workflows and prod-like concurrentLS relvals #29318

srimanob commented Mar 27, 2020 •

edited

cmsbuild commented Mar 27, 2020

cmsbuild commented Mar 27, 2020

cmsbuild commented Mar 27, 2020

cmsbuild commented Mar 27, 2020

srimanob commented Mar 27, 2020 •

edited

Dr15Jones commented Mar 27, 2020

srimanob commented Mar 27, 2020

chayanit commented Mar 30, 2020

cmsbuild commented Mar 30, 2020 •

edited

cmsbuild commented Mar 30, 2020

cmsbuild commented Mar 30, 2020

cmsbuild commented Mar 30, 2020

kpedro88 commented Apr 2, 2020

kpedro88 commented Apr 2, 2020

cmsbuild commented Apr 2, 2020 •

edited

cmsbuild commented Apr 2, 2020

cmsbuild commented Apr 2, 2020

cmsbuild commented Apr 2, 2020

kpedro88 commented Apr 3, 2020

silviodonato commented Apr 6, 2020

chayanit commented Apr 6, 2020

cmsbuild commented Apr 6, 2020

silviodonato commented Apr 6, 2020

Add EventsPerLumi for relvals workflows and prod-like concurrentLS relvals #29318

Add EventsPerLumi for relvals workflows and prod-like concurrentLS relvals #29318

Conversation

srimanob commented Mar 27, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Mar 27, 2020

cmsbuild commented Mar 27, 2020

cmsbuild commented Mar 27, 2020

cmsbuild commented Mar 27, 2020

srimanob commented Mar 27, 2020 • edited

Dr15Jones commented Mar 27, 2020

srimanob commented Mar 27, 2020

chayanit commented Mar 30, 2020

cmsbuild commented Mar 30, 2020 • edited

cmsbuild commented Mar 30, 2020

cmsbuild commented Mar 30, 2020

cmsbuild commented Mar 30, 2020

kpedro88 commented Apr 2, 2020

kpedro88 commented Apr 2, 2020

cmsbuild commented Apr 2, 2020 • edited

cmsbuild commented Apr 2, 2020

cmsbuild commented Apr 2, 2020

cmsbuild commented Apr 2, 2020

kpedro88 commented Apr 3, 2020

silviodonato commented Apr 6, 2020

chayanit commented Apr 6, 2020

cmsbuild commented Apr 6, 2020

silviodonato commented Apr 6, 2020

srimanob commented Mar 27, 2020 •

edited

srimanob commented Mar 27, 2020 •

edited

cmsbuild commented Mar 30, 2020 •

edited

cmsbuild commented Apr 2, 2020 •

edited