Replace validationHarvestingNoHLT with validationHarvesting in HI workflows

[silviodonato]

PR description:

This PR fixes the errors obtained in wf 140.0 145.0 150.0.
These errors became visible after #29343.

HARVESTING:validationHarvestingNoHLT+dqmHarvestingFakeHLT
entry file:step3_inDQM.root
Step: HARVESTING Spec: ['validationHarvestingNoHLT', 'dqmHarvestingFakeHLT']
validationHarvestingNoHLT is not a possible harvesting type. Available are [...]
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/nweek-02622/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-04-02-1100/bin/slc7_amd64_gcc820/cmsDriver.py", line 56, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/nweek-02622/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-04-02-1100/bin/slc7_amd64_gcc820/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/nweek-02622/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-04-02-1100/python/Configuration/Applications/ConfigBuilder.py", line 2127, in prepare
    self.addStandardSequences()
  File "/cvmfs/cms-ib.cern.ch/nweek-02622/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-04-02-1100/python/Configuration/Applications/ConfigBuilder.py", line 759, in addStandardSequences
    getattr(self,"prepare_"+stepName)(sequence = '+'.join(stepSpec))
  File "/cvmfs/cms-ib.cern.ch/nweek-02622/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-04-02-1100/python/Configuration/Applications/ConfigBuilder.py", line 2004, in prepare_HARVESTING
    getattr(self.process, name)
AttributeError: 'Process' object has no attribute 'validationHarvestingNoHLT'

We get this error because when we try to run HARVESTING:validationHarvestingNoHLT with --scenario HeavyIons, but validationHarvestingNoHLT is not defined in
https://github.com/cms-sw/cmssw/blob/master/Configuration/StandardSequences/python/HarvestingHeavyIons_cff.py ( called from https://github.com/cms-sw/cmssw/blob/master/Configuration/Applications/python/ConfigBuilder.py#L1040 )

HARVESTHI2018, HARVESTHI2015, HARVESTHI2011 are the only Harvesting steps used with --scenario HeavyIons

PR validation:

The output of runTheMatrix.py -l 140.0,145.0,150.0 --dryRun is ok after the fix

[cmsbuild]

The code-checks are being triggered in jenkins.

[silviodonato]

please test workflows 140.0,145.0,150.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29393/14516

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update relvals of JME customised Nano for 2016,17,18 #29279, Add EventsPerLumi for relvals workflows and prod-like concurrentLS relvals #29318

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 150.0,140.0,145.0
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5529/console Started: 2020/04/04 16:57

[cmsbuild]

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[makortel]

On the other hand these workflows seem to run HLT:fake(2), which makes me wonder if the validationHarvestingNoHLT should be defined for HI instead.

[silviodonato]

Yes, we might rename validationHarvesting to validationHarvestingNoHLT in
https://github.com/cms-sw/cmssw/blob/master/Configuration/StandardSequences/python/HarvestingHeavyIons_cff.py in order to be more similar to
https://github.com/cms-sw/cmssw/blob/master/Configuration/StandardSequences/python/Harvesting_cff.py

[cmsbuild]

+1
Tested at: c3de15a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42ed44/5529/summary.html
CMSSW: CMSSW_11_1_X_2020-04-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42ed44/5529/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-42ed44/140.0_HydjetQ_B12_5020GeV_2011+HydjetQ_B12_5020GeV_2011+DIGIHI2011+RECOHI2011+HARVESTHI2011
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-42ed44/145.0_HydjetQ_B12_5020GeV_2015+HydjetQ_B12_5020GeV_2015+DIGIHI2015+RECOHI2015+HARVESTHI2015

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692110
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2691781
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[makortel]

Yes, we might rename validationHarvesting to validationHarvestingNoHLT in

Ah, I missed (didn't check...) that HI validationHarvesting does not include HLT, sorry for the noise.

[silviodonato]

Do you agree with this fix or you have different ideas about how to fix the errors in 140.0 145.0 150.0?
@chayanit @pgunnell @wajidalikhan @kpedro88

[kpedro88]

+upgrade

[chayanit]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1