pixel mc gain calibration scheme: new GTs for MC Run3, modified Clusterizer conditions for Run3 #29333
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29333/14411
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29333/14420
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
@dkotlins this PR has code style and quality issues. Can you please resolve them as suggested at #29333 (comment)? |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29333/14422
|
|
Can AlCa please review? |
|
+1 Sorry for being late. |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
Update the Patatrack code following cms-sw#29333: Modify the scheme of the pixel gain calibration: instead of applying the VCal calibration in the clusterizer include it already in the gain calibration payload.
PR description:
Modify the scheme of the pixel gain calibration. Instead of applying the vcal calibration in the
clusterizer include it already in the gain calibration payload. Like this the vcal calibration can
be easily adjusted for each new gain calibration.
This is the first step in which we only change the MC gain calibrations. It should apply to any future Run3 simulations. Data from Run1/2 and older, none Run3 MC, will not be affected.
To be applied for Run 3 MC & Data. No code changes, the only changes are:
what changes are expected in the output if any,
No changes expected to the output
what other PRs or externals it depends upon if any,
There are no other PRs, but the change must be in sync with a GT change, this is why the autoCond.py file is also modified.
link to any additional material useful to provide a documentation for this PR (slides, JIRA tickets, related pull requestes, hypernews, TWiki or Indico pages)
https://indico.cern.ch/event/879470/contributions/3796405/attachments/2009273/3356603/pix_off_25_3_gain_calibration_mc.pdf
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport required.
The changes have been verified using Run3 simulations.