Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.1.X] Applied gain calibration scheme update at HLT as well #29959

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 22, 2020

backport of #29951

PR description:

Unfortunately the Pixel gain calibration scheme update introduced at #29333 missed the HLT configuration.
This PR provides the appropriate customization function to deal with the update of conditions also for the HLT.

PR validation:

Dumped the step3 configuration of https://cmsweb.cern.ch/couchdb/reqmgr_config_cache/95d680704ae17507a77b0e3350c8c1d5/configFile with and without this branch and obtained as expected:

$ colordiff dump.py dump2.py 
65455,65458c65455,65458
<     VCaltoElectronGain = cms.int32(47),
<     VCaltoElectronGain_L1 = cms.int32(50),
<     VCaltoElectronOffset = cms.int32(-60),
<     VCaltoElectronOffset_L1 = cms.int32(-670),
---
>     VCaltoElectronGain = cms.int32(1),
>     VCaltoElectronGain_L1 = cms.int32(1),
>     VCaltoElectronOffset = cms.int32(0),
>     VCaltoElectronOffset_L1 = cms.int32(0),
65484,65487c65484,65487
<     VCaltoElectronGain = cms.int32(47),
<     VCaltoElectronGain_L1 = cms.int32(50),
<     VCaltoElectronOffset = cms.int32(-60),
<     VCaltoElectronOffset_L1 = cms.int32(-670),
---
>     VCaltoElectronGain = cms.int32(1),
>     VCaltoElectronGain_L1 = cms.int32(1),
>     VCaltoElectronOffset = cms.int32(0),
>     VCaltoElectronOffset_L1 = cms.int32(0),
65513,65516c65513,65516
<     VCaltoElectronGain = cms.int32(47),
<     VCaltoElectronGain_L1 = cms.int32(50),
<     VCaltoElectronOffset = cms.int32(-60),
<     VCaltoElectronOffset_L1 = cms.int32(-670),
---
>     VCaltoElectronGain = cms.int32(1),
>     VCaltoElectronGain_L1 = cms.int32(1),
>     VCaltoElectronOffset = cms.int32(0),
>     VCaltoElectronOffset_L1 = cms.int32(0),
65542,65545c65542,65545
<     VCaltoElectronGain = cms.int32(47),
<     VCaltoElectronGain_L1 = cms.int32(50),
<     VCaltoElectronOffset = cms.int32(-60),
<     VCaltoElectronOffset_L1 = cms.int32(-670),
---
>     VCaltoElectronGain = cms.int32(1),
>     VCaltoElectronGain_L1 = cms.int32(1),
>     VCaltoElectronOffset = cms.int32(0),
>     VCaltoElectronOffset_L1 = cms.int32(0),

if this PR is a backport please specify the original PR and why you need to backport that PR:

Verbatim backport of #29951

cc: @tsusa @dkotlins @tvami

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2020

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_1_X.

It involves the following packages:

HLTrigger/Configuration

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2020

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2020

urgent

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6525/console Started: 2020/05/22 21:20

@mmusich mmusich changed the title [1.1.X] Applied gain calibration scheme update at HLT as well [11.1.X] Applied gain calibration scheme update at HLT as well May 22, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: 1afecc5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7dbef/6525/summary.html
CMSSW: CMSSW_11_1_X_2020-05-22-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7dbef/6525/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 13195
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2767547
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 76c767f into cms-sw:CMSSW_11_1_X May 25, 2020
@mmusich mmusich deleted the fixPixelGainCalibrationAtHLT_29333 branch May 25, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants