Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of condition updates per-lumisection #29363

Merged
merged 4 commits into from Apr 7, 2020

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Apr 1, 2020

PR description:

Adding support of condition updates with lumisection granularity. Targeted for HLT workflow.
The updates will be forced by an 'artificial' fixed lenght of the IOV, determined by configuration and set when the since value is identified for a given target event time.

PR validation:

A full test workflow for this case has been added. The existing unit tests are running.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29363/14462

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29363/14463

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondCore/ESSources
CondCore/Utilities

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented Apr 1, 2020

@wddgit can you please have a look? Feedback wellcome

@ggovi
Copy link
Contributor Author

ggovi commented Apr 1, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5483/console Started: 2020/04/01 14:01

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

+1
Tested at: 3218b5f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ca373/5483/summary.html
CMSSW: CMSSW_11_1_X_2020-04-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

Comparison job queued.

@ggovi
Copy link
Contributor Author

ggovi commented Apr 3, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2020

The tests are being triggered in jenkins.

@ggovi
Copy link
Contributor Author

ggovi commented Apr 6, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5546/console Started: 2020/04/06 11:58

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2020

+1
Tested at: 05c7fca
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ca373/5546/summary.html
CMSSW: CMSSW_11_1_X_2020-04-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ca373/5546/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691745
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented Apr 6, 2020

+1

@pohsun
Copy link

pohsun commented Apr 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 102e554 into cms-sw:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants