-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of condition updates per-lumisection #29363
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29363/14462
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29363/14463
|
A new Pull Request was created by @ggovi for master. It involves the following packages: CondCore/ESSources @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@wddgit can you please have a look? Feedback wellcome |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Adding support of condition updates with lumisection granularity. Targeted for HLT workflow.
The updates will be forced by an 'artificial' fixed lenght of the IOV, determined by configuration and set when the since value is identified for a given target event time.
PR validation:
A full test workflow for this case has been added. The existing unit tests are running.