Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of TSG internal GTs #29378

Merged
merged 1 commit into from Apr 2, 2020
Merged

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Remove use of TSG internal GTs
(as exposed by #29357)

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

The code-checks are being triggered in jenkins.

@Martin-Grunewald
Copy link
Contributor Author

please test workflow 503.0,561.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29378/14482

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

pdmv: @chayanit @pgunnell @zhenhu
upgrade: @kpedro88

If you have no objections, I'm going to merge this PR before the morning IB because it fixes many failing workflows.

@chayanit
Copy link

chayanit commented Apr 2, 2020

+1
no objection

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

+1
Tested at: 17697a9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-268d2d/5498/summary.html
CMSSW: CMSSW_11_1_X_2020-04-01-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

Comparison job queued.

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 778397f into cms-sw:master Apr 2, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-268d2d/5498/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-268d2d/503.0_MinBias_13TeV_pythia8+MinBias_13TeV_pythia8+HARVESTGEN
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-268d2d/561.0_WprimeTolNu_M3000_13TeV_pythia8+WprimeTolNu_M3000_13TeV_pythia8+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 28
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691763
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 2, 2020

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@Martin-Grunewald Martin-Grunewald deleted the FixUseOfTsgGTs branch October 27, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants