Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phase2 tracker premixed digis #29565

Merged
merged 3 commits into from Apr 30, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 27, 2020

resolves #29563

PR description:

Solves the two issues reported at #29563 by:

  1. allowing the collections of PixelDigis produced by the premixing stage-1 and the signal digitization in step2 with two different conversion factor for IT and OT and then let the PreMixingPhase2TrackerWorker to undo the conversion separately for IT and OT.
  2. configuring the Phase-2 digitizer to have analog readout for OT (for the PSS layers) at step 1 of pre-mixing, as actual charge information is essential.

PR validation:

Validation has been run twice:

  • I tested wf 23461.99 (SingleNu gun - premixed, PU=200, Geometry = D49) and compared it with the same workflow run in a vanilla CMSSW_11_1_0_pre6 release and with the equivalent standard mixing workflow 23461.0 (SingleNu gun - standard mixing, PU=200, Geometry = D49).
  • @suchandradutta tested also the changes with a signal TTbar + PU=200 sample and obtained the results below:
  1. IT digis issue:
    image

  2. OT digis issue:
    image

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.
@suchandradutta @emiglior @skinnari @tsusa

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29565/14865

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29565/14867

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

SimGeneral/PreMixingModule
SimTracker/SiPhase2Digitizer

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

test parameters
workflows = 20634.99

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 66a11ff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9f5d4/5870/summary.html
CMSSW: CMSSW_11_1_X_2020-04-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@kpedro88
Copy link
Contributor

+upgrade

@civanch
Copy link
Contributor

civanch commented Apr 29, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

please test workflow 23234.1001, 23434.1001

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 66a11ff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9f5d4/5894/summary.html
CMSSW: CMSSW_11_1_X_2020-04-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9f5d4/5894/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e9f5d4/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e9f5d4/23434.1001_TTbar_14TeV+RecoFullGlobalPU_TestOldDigi_2026D49PU+HARVESTFullGlobalPU_2026D49PU

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696114
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phase2 Tracker Premixed DIGIs are broken
5 participants