[LLVM10] Fixing compilation warnings for SIM #29598

smuzaffar · 2020-04-30T10:04:44Z

PR description:

LLVM 10 integration in CLANG IBs shows new compilation warnings. This PR addresses few of those coming from packages belong to simulation

PR validation:

Local compilation for CLANG and normal IBs show no warnings.

cmsbuild · 2020-04-30T10:05:11Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-30T10:09:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29598/14932

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_Listgroups.cc modified in PR(s): DD4hep: SimTracker/TrackerMaterialAnalysis Migration MaterialAccounting #29577

cmsbuild · 2020-04-30T10:09:46Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

SimGeneral/CaloAnalysis
SimTracker/TrackerMaterialAnalysis

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @apsallid, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2020-04-30T10:10:57Z

please test

cmsbuild · 2020-04-30T10:11:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5925/console Started: 2020/04/30 12:17

cmsbuild · 2020-04-30T11:28:18Z

+1
Tested at: 43bcadf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74670/5925/summary.html
CMSSW: CMSSW_11_1_X_2020-04-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-30T11:28:20Z

Comparison job queued.

cmsbuild · 2020-04-30T13:07:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74670/5925/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696435
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696115
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

civanch · 2020-04-30T22:06:18Z

+1
rebase required

cmsbuild · 2020-04-30T22:06:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-01T09:15:22Z

SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_Listgroups.cc

@@ -257,7 +257,8 @@ void DD4hep_ListGroups::analyze(const edm::Event &evt, const edm::EventSetup &se
    bool firstChild = fv1.firstChild();

    for (const auto j : fv1.specpars()) {
-      for (const auto k : j->paths) {
+      for (const auto &k : j->paths) {
+        std::cout << k << std::endl;


@smuzaffar are you adding this line on purpose?

No it was a mistake to keep this line. I have fixed it. thanks for extra pairs of eyes.

smuzaffar · 2020-05-01T11:01:19Z

please test

cmsbuild · 2020-05-01T11:03:23Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-01T11:08:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29598/14951

This PR adds an extra 20KB to repository

cmsbuild · 2020-05-01T11:08:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5942/console Started: 2020/05/01 13:24

cmsbuild · 2020-05-01T11:08:59Z

Pull request #29598 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

cmsbuild · 2020-05-01T12:36:29Z

+1
Tested at: 9e16e7f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74670/5942/summary.html
CMSSW: CMSSW_11_1_X_2020-04-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-01T12:36:32Z

Comparison job queued.

silviodonato · 2020-05-01T13:37:45Z

merge

cmsbuild · 2020-05-01T14:06:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d74670/5942/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696239
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2695918
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

fix llvm 10 warnings: avoid loop variable copy

43bcadf

cmsbuild added this to the CMSSW_11_1_X milestone Apr 30, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Apr 30, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 30, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 30, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 30, 2020

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Apr 30, 2020

cmsbuild added the comparison-available label May 1, 2020

silviodonato reviewed May 1, 2020

View reviewed changes

removed the cout which was mistakenly kept during the merge conflict

9e16e7f

cmsbuild added code-checks-pending comparison-pending tests-pending and removed code-checks-approved comparison-available tests-approved labels May 1, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 1, 2020

cmsbuild added tests-started and removed tests-pending labels May 1, 2020

cmsbuild added tests-approved and removed tests-started labels May 1, 2020

cmsbuild added orp-approved and removed orp-pending labels May 1, 2020

cmsbuild merged commit 30ddd9a into cms-sw:master May 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 1, 2020

cmsbuild mentioned this pull request May 2, 2020

initialize std::array data member in TICLCandidate #29616

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LLVM10] Fixing compilation warnings for SIM #29598

[LLVM10] Fixing compilation warnings for SIM #29598

smuzaffar commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

smuzaffar commented Apr 30, 2020

cmsbuild commented Apr 30, 2020 •

edited

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

civanch commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

silviodonato May 1, 2020

smuzaffar May 1, 2020

smuzaffar commented May 1, 2020

cmsbuild commented May 1, 2020

cmsbuild commented May 1, 2020

cmsbuild commented May 1, 2020 •

edited

cmsbuild commented May 1, 2020

cmsbuild commented May 1, 2020

cmsbuild commented May 1, 2020

silviodonato commented May 1, 2020

cmsbuild commented May 1, 2020

[LLVM10] Fixing compilation warnings for SIM #29598

[LLVM10] Fixing compilation warnings for SIM #29598

Conversation

smuzaffar commented Apr 30, 2020

PR description:

PR validation:

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

smuzaffar commented Apr 30, 2020

cmsbuild commented Apr 30, 2020 • edited

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

civanch commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

silviodonato May 1, 2020

Choose a reason for hiding this comment

smuzaffar May 1, 2020

Choose a reason for hiding this comment

smuzaffar commented May 1, 2020

cmsbuild commented May 1, 2020

cmsbuild commented May 1, 2020

cmsbuild commented May 1, 2020 • edited

cmsbuild commented May 1, 2020

cmsbuild commented May 1, 2020

cmsbuild commented May 1, 2020

silviodonato commented May 1, 2020

cmsbuild commented May 1, 2020

cmsbuild commented Apr 30, 2020 •

edited

cmsbuild commented May 1, 2020 •

edited