[LLVM10] PhysicsTools fix clang warnings

[mrodozov]

PR description:

Fix warnings in PhysicsTools,
please see the PhysicsTools/PatUtils one the others are trivial
the warning about it is here:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_1_CLANG_X_2020-04-27-2300/PhysicsTools/PatUtils

PR validation:

Builds without warnings with the CLANG IB

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

please test for CMSSW_11_1_CLANG_X_2020-04-27-2300

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29581/14898

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/ONNXRuntime/test/testONNXRuntime.cc modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/ONNXRuntime
PhysicsTools/PatUtils

@perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test for CMSSW_11_1_CLANG_X

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• RELEASE_FORMAT = CMSSW_11_1_CLANG_X
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5899/console Started: 2020/04/29 14:35

[cmsbuild]

+1
Tested at: 4e05083
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc41b/5899/summary.html
CMSSW: CMSSW_11_1_CLANG_X_2020-04-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc41b/5899/summary.html

Comparison Summary:

• You potentially added 5001 lines to the logs
• Reco comparison results: 13853 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696435
• DQMHistoTests: Total failures: 114302
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 2581808
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.016 KiB( 33 files compared)
• DQMHistoSizes: changed ( 136.793 ): -0.020 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 4.53 ): 0.004 KiB JetMET/SUSYDQM
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

@cmsbuild please test

for clean comparisons

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5970/console Started: 2020/05/04 14:40

[cmsbuild]

Pull request #29581 was updated. @perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please check and sign again.

[cmsbuild]

+1
Tested at: d683d55
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc41b/5970/summary.html
CMSSW: CMSSW_11_1_X_2020-05-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc41b/5970/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696239
• DQMHistoTests: Total failures: 25
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2695895
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[perrotta]

+1

• Technical
• Jenkins tests pass

[santocch]

+1

[silviodonato]

merge
@peruzzim please let me know if you have any objections