Clean up BuildFiles under Calibration/ #29648

fwyzard · 2020-05-05T10:36:32Z

Clean up BuildFile.xml filea with xmllint --format.

fwyzard · 2020-05-05T10:36:33Z

@cmsbuild, please test

cmsbuild · 2020-05-05T10:37:00Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-05T10:42:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29648/15044

This PR adds an extra 24KB to repository

cmsbuild · 2020-05-05T10:43:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6014/console Started: 2020/05/05 12:43

cmsbuild · 2020-05-05T10:43:22Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

Calibration/EcalAlCaRecoProducers
Calibration/EcalCalibAlgos
Calibration/EcalTBTools
Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
Calibration/HcalConnectivity
Calibration/HcalIsolatedTrackReco
Calibration/IsolatedParticles
Calibration/LumiAlCaRecoProducers
Calibration/TkAlCaRecoProducers
Calibration/Tools

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-05-05T11:50:47Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-05T11:52:20Z

-1

Tested at: bbd97d9

CMSSW: CMSSW_11_1_X_2020-05-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Add time support to IPCutPFCandidateSelector #29596 @dntaylor: Add time support to IPCutPFCandidateSelector
Clean buildfiles in DQM #29579 @guitargeek: Clean buildfiles in DQM
[LLVM10] L1Trigger and L1TriggerConfig fix clang warnings #29587 @mrodozov: [LLVM10] L1Trigger and L1TriggerConfig fix clang warnings
[LLVM10] PhysicsTools fix clang warnings #29581 @mrodozov: [LLVM10] PhysicsTools fix clang warnings
[LLVM10] OnlineDB fix clang warnings #29583 @mrodozov: [LLVM10] OnlineDB fix clang warnings
added missing dependency; header cleanup #29613 @smuzaffar: added missing dependency; header cleanup
Run3-sim69 Add a few cfi files which defines transition energies for standard G4 versions #29625 @bsunanda: Run3-sim69 Add a few cfi files which defines transition energies for standard G4 versions
ElectronNHitSeedProducer modernization #29512 @guitargeek: ElectronNHitSeedProducer modernization

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ed76/6014/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ed76/6014/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ed76/6014/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: PUDumper.cc:(.text+0x4c4): undefined reference to `TFileDirectory::_cd(std::__cxx11::basic_string, std::allocator > const&, bool) const'
/cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: PUDumper.cc:(.text+0x52a): undefined reference to `TH1AddDirectorySentry::TH1AddDirectorySentry()'
/cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: PUDumper.cc:(.text+0x53b): undefined reference to `TH1AddDirectorySentry::~TH1AddDirectorySentry()'
/cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/Calibration/EcalAlCaRecoProducers/plugins/CalibrationEcalAlCaRecoProducersAuto/PUDumper.cc.o: in function `PUDumper::PUDumper(edm::ParameterSet const&) [clone .cold.151]':
PUDumper.cc:(.text.unlikely+0x3f): undefined reference to `TH1AddDirectorySentry::~TH1AddDirectorySentry()'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc820/src/Calibration/EcalAlCaRecoProducers/plugins/CalibrationEcalAlCaRecoProducersAuto/libCalibrationEcalAlCaRecoProducersAuto.so] Error 1
Leaving library rule at src/Calibration/EcalAlCaRecoProducers/plugins
Entering library rule at Calibration/EcalAlCaRecoProducers
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-04-2300/src/Calibration/EcalAlCaRecoProducers/src/ValueMapTraslator.cc 
>> Building shared library tmp/slc7_amd64_gcc820/src/Calibration/EcalAlCaRecoProducers/src/CalibrationEcalAlCaRecoProducers/libCalibrationEcalAlCaRecoProducers.so

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Add time support to IPCutPFCandidateSelector #29596 @dntaylor: Add time support to IPCutPFCandidateSelector
Clean buildfiles in DQM #29579 @guitargeek: Clean buildfiles in DQM
[LLVM10] L1Trigger and L1TriggerConfig fix clang warnings #29587 @mrodozov: [LLVM10] L1Trigger and L1TriggerConfig fix clang warnings
[LLVM10] PhysicsTools fix clang warnings #29581 @mrodozov: [LLVM10] PhysicsTools fix clang warnings
[LLVM10] OnlineDB fix clang warnings #29583 @mrodozov: [LLVM10] OnlineDB fix clang warnings
added missing dependency; header cleanup #29613 @smuzaffar: added missing dependency; header cleanup
Run3-sim69 Add a few cfi files which defines transition energies for standard G4 versions #29625 @bsunanda: Run3-sim69 Add a few cfi files which defines transition energies for standard G4 versions
ElectronNHitSeedProducer modernization #29512 @guitargeek: ElectronNHitSeedProducer modernization

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ed76/6014/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ed76/6014/git-merge-result

cmsbuild · 2020-05-05T11:52:22Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-05-05T11:57:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29648/15048

This PR adds an extra 24KB to repository

cmsbuild · 2020-05-05T11:57:57Z

Pull request #29648 was updated. @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please check and sign again.

fwyzard · 2020-05-05T12:42:06Z

hold

cmsbuild · 2020-05-05T12:42:34Z

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

Clean up BuildFile.xml filea with `xmllint --format`.

cmsbuild · 2020-05-05T15:54:57Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-05-05T15:55:12Z

unhold

fwyzard · 2020-05-05T15:55:20Z

@cmsbuild, please test

cmsbuild · 2020-05-05T15:59:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29648/15150

This PR adds an extra 24KB to repository

cmsbuild · 2020-05-05T15:59:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6114/console Started: 2020/05/05 22:13

cmsbuild · 2020-05-05T15:59:42Z

Pull request #29648 was updated. @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please check and sign again.

cmsbuild · 2020-05-05T22:23:49Z

+1
Tested at: ae105ae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ed76/6114/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Clean up BuildFiles under HLTriggerOffline/ #29637 @fwyzard: Clean up BuildFiles under HLTriggerOffline/
Added particle flow candidates to particle flow validation #29628 @chosila: Added particle flow candidates to particle flow validation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ed76/6114/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ed76/6114/git-merge-result

cmsbuild · 2020-05-05T22:23:52Z

Comparison job queued.

cmsbuild · 2020-05-06T07:16:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7ed76/6114/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696239
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2695901
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
Checked 147 log files, 16 edm output root files, 34 DQM output files

silviodonato · 2020-05-06T12:55:45Z

Calibration/EcalAlCaRecoProducers/plugins/BuildFile.xml

-<use   name="Geometry/CaloGeometry"/>
-<use   name="CalibTracker/Records"/>
-<flags   EDM_PLUGIN="1"/>
+<use name="clhep"/>


removed the comment and sorted

silviodonato · 2020-05-06T14:27:26Z

merge

cmsbuild added this to the CMSSW_11_1_X milestone May 5, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels May 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2020

cmsbuild added tests-started and removed tests-pending labels May 5, 2020

fwyzard force-pushed the branch_lintBuildFile_Calibration branch from bbd97d9 to ba8c44a Compare May 5, 2020 11:50

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels May 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2020

cmsbuild added the hold label May 5, 2020

Clean up BuildFiles under Calibration/

ae105ae

Clean up BuildFile.xml filea with `xmllint --format`.

fwyzard force-pushed the branch_lintBuildFile_Calibration branch from ba8c44a to ae105ae Compare May 5, 2020 15:54

cmsbuild added code-checks-pending and removed code-checks-approved labels May 5, 2020

cmsbuild removed the hold label May 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2020

cmsbuild added tests-started and removed tests-pending labels May 5, 2020

cmsbuild added tests-approved and removed tests-started labels May 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 6, 2020

silviodonato reviewed May 6, 2020

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels May 6, 2020

cmsbuild merged commit 526b692 into cms-sw:master May 6, 2020

fwyzard deleted the branch_lintBuildFile_Calibration branch May 8, 2020 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up BuildFiles under Calibration/ #29648

Clean up BuildFiles under Calibration/ #29648

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 •

edited

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 •

edited

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 6, 2020

silviodonato May 6, 2020

fwyzard May 6, 2020

silviodonato commented May 6, 2020

Clean up BuildFiles under Calibration/ #29648

Clean up BuildFiles under Calibration/ #29648

Conversation

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 • edited

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 • edited

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 6, 2020

silviodonato May 6, 2020

Choose a reason for hiding this comment

fwyzard May 6, 2020

Choose a reason for hiding this comment

silviodonato commented May 6, 2020

cmsbuild commented May 5, 2020 •

edited

cmsbuild commented May 5, 2020 •

edited