add track filter for N tracks with minimum pt

[antoniovagnerini]

EDFilter to be used in the cosmics during collision (CDC) trigger @HLT
It selects N tracks passing a certain pT cut.

This PR is a follow-up of the PR #21241 and it uses the template approach suggested previously.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/14941

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/14941/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/14941/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mtosi]

@antoniovagnerini thanks !
are you going to add the possibility of using other criteria (like the #hits, the eta acceptance, ..) as well ?

[antoniovagnerini]

@mtosi thank you, this is a good point. For the moment, this only performs a cut on the track candidate pT, but in principle one can add in the Fill Description template some extra parameters. I will have a look.

[slava77]

Code check has found code style and quality issues which could be resolved by applying following patch(s)

these have to be addressed before other tests can run

[slava77]

@antoniovagnerini
please clarify on the status of this PR.
Thank you.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/15338

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/15338/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/15338/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/15340

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/15340/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/15340/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[slava77]

@cmsbuild please abort test

[cmsbuild]

Jenkins tests are aborted.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6313/console Started: 2020/05/14 18:54

[cmsbuild]

+1
Tested at: 42f3ef6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cee422/6313/summary.html
CMSSW: CMSSW_11_1_X_2020-05-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cee422/6313/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2702162
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2701841
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[slava77]

+1

for #29604 42f3ef6

• code changes are in line with the PR description; the implementation is rather straightforward
• jenkins tests pass and comparisons with the baseline show no (relevant) differences (the new module is not used in the standard workflows)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

@antoniovagnerini have you consider to use a generic CandViewSelector?

https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuidePhysicsCutParser
Something like

process.selector5 = cms.EDFilter("CandViewSelector",
    src = cms.InputTag("genParticles"),
    cut = cms.string("pt > 5.0")
)
process.filter = cms.EDFilter("PATCandViewCountFilter", 
    maxNumber = cms.uint32(999), 
    src = cms.InputTag("selector5"), 
    minNumber = cms.uint32(1)
)

[antoniovagnerini]

The idea of this PR was to introduce an ED filter specifically for tracks, enabling pT and other cut variables. As discussed in #21241, this kind of approach is needed for Cosmic During Collision track reconstruction.

[silviodonato]

+1