added missing dependency; header cleanup

[smuzaffar]

Adding missing dependency on DataFormats/EcalDigi which is used by [a]. Although it is header only dependency but by definition we should have it in BuildFile too.
Cleanup unused include header too.

[a]

CondFormats/EcalObjects/src/EcalSampleMask.cc:#include "DataFormats/EcalDigi/interface/EcalDataFrame.h"
CondFormats/EcalObjects/src/EcalSampleMask.cc:  sampleMaskEB_ = pow(2, EcalDataFrame::MAXSAMPLES) - 1;
CondFormats/EcalObjects/src/EcalSampleMask.cc:  sampleMaskEE_ = pow(2, EcalDataFrame::MAXSAMPLES) - 1;

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29613/14958

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondFormats/EcalObjects/BuildFile.xml modified in PR(s): BuildFile cleanup: removed unnecessary dependencies #29608

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5949/console Started: 2020/05/01 20:18

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondFormats/EcalObjects

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: c0a38e1

CMSSW: CMSSW_11_1_X_2020-05-01-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a0cc5/5949/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-01-1100/src/SimCalorimetry/EcalZeroSuppressionProducers/src/EcalZeroSuppressionProducer.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-01-1100/src/SimCalorimetry/EcalZeroSuppressionProducers/src/ESZeroSuppressionProducer.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-01-1100/src/SimCalorimetry/EcalZeroSuppressionProducers/src/SealModule.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-01-1100/src/SimCalorimetry/EcalZeroSuppressionProducers/interface/EcalZeroSuppressionProducer.h:4,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-01-1100/src/SimCalorimetry/EcalZeroSuppressionProducers/src/EcalZeroSuppressionProducer.cc:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-01-1100/src/CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h:297:43: error: 'EcalDataFrame' was not declared in this scope
   std::vector >
                                           ^~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-01-1100/src/CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h:297:43: note: suggested alternative: 'EcalFunParams'
   std::vector >
                                           ^~~~~~~~~~~~~


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29613/14964

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #29613 was updated. @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please check and sign again.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5953/console Started: 2020/05/01 23:44

[cmsbuild]

+1
Tested at: 13087e0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a0cc5/5953/summary.html
CMSSW: CMSSW_11_1_X_2020-05-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a0cc5/5953/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696239
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2695919
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[pohsun]

+1

[silviodonato]

merge
@ggovi please let me know if you have any objections