Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added particle flow candidates to particle flow validation #29628

Merged
merged 16 commits into from May 5, 2020
Merged

Added particle flow candidates to particle flow validation #29628

merged 16 commits into from May 5, 2020

Conversation

chosila
Copy link
Contributor

@chosila chosila commented May 4, 2020

PR description:
This PR adds PFCandidates (packedCandidates) to the particle flow validation package, as well as included some JetMET plots in the plotting script. The packedCandidates histograms can be found in the DQM files under ParticleFlow/Run summary/PackedCandidates.

our plotting script, found in RecoParticleFlow/test/compare.py was also changed to accommodate the changes in the DQM files.

PR validation:
http://hep.baylor.edu/chosila/PFVal/plots_JetMET_PFCand/
Shows the histograms made with compare.py and the DQM files made using the modified scrips in this PR. The sampled used in the plots were the same QCD sample, so it looks like only 1 sample is visible.

nohup runTheMatrix.py -l 11634.0 -j 8 &>11634.0.log &
nohup runTheMatrix.py -l 23234.0 -j 8 &>23234.0.log &

Were also ran in addition to the QCD samples, and produces the expected outputs with no failures.

if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport.

@hatakeyamak @bendavid @juska

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29628/15005

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2020

A new Pull Request was created by @chosila for master.

It involves the following packages:

DQMOffline/Configuration
Validation/RecoParticleFlow

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rociovilar, @threus, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented May 4, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5979/console Started: 2020/05/04 18:34

This was referenced May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants