Restructured code of againstElectronDeadECAL tauID (10_2_X) #29747

mbluj · 2020-05-06T11:14:22Z

PR description:

Restructured code of againstElectronDeadECAL discriminator to run on either AOD or miniAOD inputs (backport of #29627):

add a version of the discriminant to run on top of pat::Taus to be used with miniAOD data samples;
use eta and phi of impact position of the leading PFChargedHadron on ECal surface instead of eta and phi of tau at the vertex (taking bending of track in the magnetic field and the zVertex into account) - feature disabled by default for backwards compatibility;
restructure the code in the way that both AOD and miniAOD version of the discriminant call the same algorithm to avoid code duplication;
move code performing the extrapolation to the ECal surface from the againstElectronMVA algorithm to an auxiliary helper class which avoids code duplication;

Expected some differences:

none with default workflows

PR validation:

runTheMatrix.py -l limited -i all passed successfully except a few failed due to problem with inputs (DAS_ERROR).

if this PR is a backport please specify the original PR and why you need to backport that PR:

It is backport of #29627

…n either AOD or miniAOD inputs - use eta and phi of impact position of leadingPFChargedHadron on ECAL surface instead of eta and phi of tau at the vertex (taking bending of track in the magnetic field and the zVertex into account; disabled by default for backwards compatiblity)

…n ECAL surface (instead of taking eta and phi of tau at the vertex) when running againstElectronDeadECAL discriminator on AOD level (for backwards compatibility) - removed debug output

…atibility

…metics

cmsbuild · 2020-05-06T11:14:54Z

A new Pull Request was created by @mbluj for CMSSW_10_2_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoTauTag/RecoTau

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Backported from Restructured code of againstElectronDeadECAL tauID #29627

perrotta · 2020-05-06T12:14:49Z

backport of #29627

cmsbuild · 2020-05-18T10:22:18Z

Pull request #29747 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

slava77 · 2020-05-22T18:19:02Z

@cmsbuild please test

cmsbuild · 2020-05-22T18:19:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6521/console Started: 2020/05/22 20:24

slava77

To be updated, to match the 106X or the master:

RecoTauTag/RecoTau/interface/TauDiscriminationProducerBase.h getProducerString and similarly in TauDiscriminationProducerBase.cc
RecoTauTag/RecoTau/plugins/TauDiscriminationAgainstElectronDeadECAL.cc
RecoTauTag/RecoTau/src/AntiElectronIDMVA6.cc

RecoTauTag/RecoTau/plugins/TauDiscriminationAgainstElectronDeadECAL.cc

RecoTauTag/RecoTau/src/AntiElectronIDMVA6.cc

cmsbuild · 2020-05-22T19:40:21Z

+1
Tested at: 1c372c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d65212/6521/summary.html
CMSSW: CMSSW_10_2_X_2020-05-22-1100
SCRAM_ARCH: slc6_amd64_gcc700

cmsbuild · 2020-05-22T19:40:24Z

Comparison job queued.

cmsbuild · 2020-05-22T20:31:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d65212/6521/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 3007544
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3007353
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 129 log files, 14 edm output root files, 31 DQM output files

cmsbuild · 2020-05-25T09:10:17Z

Pull request #29747 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

slava77 · 2020-05-25T12:39:58Z

@cmsbuild please test

cmsbuild · 2020-05-25T12:40:16Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6564/console Started: 2020/05/25 14:50

cmsbuild · 2020-05-25T14:03:39Z

+1
Tested at: c7466f5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d65212/6564/summary.html
CMSSW: CMSSW_10_2_X_2020-05-25-1100
SCRAM_ARCH: slc6_amd64_gcc700

cmsbuild · 2020-05-25T14:03:42Z

Comparison job queued.

cmsbuild · 2020-05-25T14:51:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d65212/6564/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 3007544
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3007351
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 129 log files, 14 edm output root files, 31 DQM output files

santocch · 2020-05-26T07:16:31Z

+1

slava77 · 2020-05-27T00:01:28Z

+1

for #29747 c7466f5

this backport PR is consistent with the master version; more close to the 106X version of the backport as in Restructured code of againstElectronDeadECAL tauID (10_6_X) #29739 (except for no extra change added in PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py: the default behavior is unchanged and apparently there is no change to add the PAT/miniAOD-based deadECAL discriminant in the run2_miniAOD_devel here
jenkins tests pass and comparisons with the baseline show no (relevant) differences

cmsbuild · 2020-05-27T00:01:55Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-27T07:52:09Z

+1

veelken and others added 5 commits April 27, 2020 17:16

add discriminator againstElectronDeadECAL to pat::Taus

1a9b267

- disabled computation of impact position of leadingPFChargedHadron o…

d846a81

…n ECAL surface (instead of taking eta and phi of tau at the vertex) when running againstElectronDeadECAL discriminator on AOD level (for backwards compatibility) - removed debug output

Remove deadECal tauID from default patTau configuration for back comp…

2de5c0a

…atibility

Change argument of deadECal operator(), add verbosity, code style cos…

048b055

…metics

cmsbuild added this to the CMSSW_10_2_X milestone May 6, 2020

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 6, 2020

mbluj mentioned this pull request May 6, 2020

Add tauID against electrons in deadECAL regions cms-nanoAOD/cmssw#519

Closed

cmsbuild added the backport label May 6, 2020

Comments from review

1c372c5

cmsbuild added tests-started and removed tests-pending labels May 22, 2020

slava77 reviewed May 22, 2020

View reviewed changes

RecoTauTag/RecoTau/plugins/TauDiscriminationAgainstElectronDeadECAL.cc Outdated Show resolved Hide resolved

RecoTauTag/RecoTau/src/AntiElectronIDMVA6.cc Show resolved Hide resolved

cmsbuild added tests-approved and removed tests-started labels May 22, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 22, 2020

cmsbuild added comparison-pending tests-pending and removed tests-approved labels May 25, 2020

cmsbuild added tests-started and removed tests-pending labels May 25, 2020

cmsbuild added tests-approved and removed tests-started labels May 25, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 25, 2020

cmsbuild added analysis-approved and removed analysis-pending labels May 26, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels May 27, 2020

cmsbuild added orp-approved and removed orp-pending labels May 27, 2020

cmsbuild merged commit 5961530 into cms-sw:CMSSW_10_2_X May 27, 2020

mbluj deleted the CMSSW_10_2_X_tau-pog_deadECAL branch May 28, 2020 08:45

mbluj mentioned this pull request May 29, 2020

Add tauID against electrons in dead ECal regions (102X) cms-nanoAOD/cmssw#522

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restructured code of againstElectronDeadECAL tauID (10_2_X) #29747

Restructured code of againstElectronDeadECAL tauID (10_2_X) #29747

mbluj commented May 6, 2020

cmsbuild commented May 6, 2020 •

edited

perrotta commented May 6, 2020

cmsbuild commented May 18, 2020

slava77 commented May 22, 2020

cmsbuild commented May 22, 2020 •

edited

slava77 left a comment

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 25, 2020

slava77 commented May 25, 2020

cmsbuild commented May 25, 2020 •

edited

cmsbuild commented May 25, 2020

cmsbuild commented May 25, 2020

cmsbuild commented May 25, 2020

santocch commented May 26, 2020

slava77 commented May 27, 2020

cmsbuild commented May 27, 2020

silviodonato commented May 27, 2020

Restructured code of againstElectronDeadECAL tauID (10_2_X) #29747

Restructured code of againstElectronDeadECAL tauID (10_2_X) #29747

Conversation

mbluj commented May 6, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 6, 2020 • edited

perrotta commented May 6, 2020

cmsbuild commented May 18, 2020

slava77 commented May 22, 2020

cmsbuild commented May 22, 2020 • edited

slava77 left a comment

Choose a reason for hiding this comment

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 22, 2020

cmsbuild commented May 25, 2020

slava77 commented May 25, 2020

cmsbuild commented May 25, 2020 • edited

cmsbuild commented May 25, 2020

cmsbuild commented May 25, 2020

cmsbuild commented May 25, 2020

santocch commented May 26, 2020

slava77 commented May 27, 2020

cmsbuild commented May 27, 2020

silviodonato commented May 27, 2020

cmsbuild commented May 6, 2020 •

edited

cmsbuild commented May 22, 2020 •

edited

cmsbuild commented May 25, 2020 •

edited