Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT DQM legacy modules removal #29784

Merged
merged 15 commits into from May 15, 2020
Merged

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented May 8, 2020

PR description:

This PR tries to asses the issue #25090 in what concerns DT DQM Legacy modules.

The four conflicting classes:

DTDataIntegrityTask
DTDCSByLumiTask
DTResolutionAnalysisTask
DTSegmentAnalysisTask

are reconfigured to clear any conflicting module with concurrent LS or dropped their usage from DQM Offline configurations, leaving all the vs LS plots ONLY for DQM Online and removing them from DQM Offline.

The results imply a drop of 71 plots from workflows. Some other cleaning of the code has been done in parallel

PR validation:

Tested for DQM Online stand alone and with:

runTheMatrix.py -l limited

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport is foreseen

(Partially) Resolves #25090

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29784/15241

  • This PR adds an extra 112KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQM/DTMonitorClient
DQM/DTMonitorModule
DQM/Integration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor Author

jfernan2 commented May 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6190/console Started: 2020/05/08 20:51

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

+1
Tested at: 7adfbbe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b6857/6190/summary.html
CMSSW: CMSSW_11_1_X_2020-05-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #29826
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6309/console Started: 2020/05/14 17:58

@jfernan2
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6330/console Started: 2020/05/15 10:15

@cmsbuild
Copy link
Contributor

+1
Tested at: 2861dad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b6857/6330/summary.html
CMSSW: CMSSW_11_1_X_2020-05-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b6857/6330/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2700218
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2700168
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -756.945 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -26.971 KiB DT/02-Segments
  • DQMHistoSizes: changed ( 1000.0,... ): -1.064 KiB DT/EventInfo
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor Author

+dqm
Changes as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modules prohibiting concurrent lumis in RelVal workflows
3 participants