Replace LumiScaler with OnlineMetaData for Run3 in TrackingDQM #29810

arossi83 · 2020-05-12T13:30:33Z

PR description:

inside the TrackingDQM some information about luminosity are retrieve via LumiScalers, with this PR the same info will be taken from OnlineMetaData in Run3 Era. The switch take place via Era modifiers.

PR validation:

Tested via standard WF:
runTheMatrix.sh -l 11634.0
runTheMatrix.sh -l 138.1

but also manually running the code over a 2018 run (325308) with Era Run3 condition in order to check the access to OnlineMetaData info:

cmsDrive step1 -s RAW2DIGI,L1Reco,RECO,DQM -n 100 --eventcontent DQM --datatier DQMIO --conditions 110X_dataRun3_Prompt_v3 --filein /store/express/Run2018E/ExpressPhysics/FEVT/Express-v1/000/325/308/00000/B2080A23-0CFB-6F47-8250-D18B7CC16B45.root --data --no_exec --python_filename=runFirst.py --era Run3
cmsDrive step3_DT1_1 -s HARVESTING:dqmHarvesting --filein file:step1_RAW2DIGI_L1Reco_RECO_DQM.root --filetype DQM --scenario pp --data --no_exec --conditions 110X_dataRun3_Prompt_v3 --python_filename=runSecond.py --era Run3
cmsRun runFirst.py
cmsRun runSecond.py

Not a Backport and no backport foreseen

cmsbuild · 2020-05-12T13:31:06Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-12T13:37:51Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29810/15314

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/TrackingMonitor/interface/TrackAnalyzer.h modified in PR(s): TRK DQM : add dz and dzErr profiles #29455
- File DQM/TrackingMonitor/python/TrackingMonitor_cfi.py modified in PR(s): TRK DQM : add dz and dzErr profiles #29455
- File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): TRK DQM : add dz and dzErr profiles #29455

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29810/15314/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29810/15314/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-05-12T13:58:49Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-12T14:05:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29810/15315

This PR adds an extra 68KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/TrackingMonitor/interface/TrackAnalyzer.h modified in PR(s): TRK DQM : add dz and dzErr profiles #29455
- File DQM/TrackingMonitor/python/TrackingMonitor_cfi.py modified in PR(s): TRK DQM : add dz and dzErr profiles #29455
- File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): TRK DQM : add dz and dzErr profiles #29455

cmsbuild · 2020-05-12T14:05:41Z

A new Pull Request was created by @arossi83 (Alessandro Rossi) for master.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorSource

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2020-05-12T14:26:43Z

please test

cmsbuild · 2020-05-12T14:27:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6251/console Started: 2020/05/12 16:35

arossi83 · 2020-05-12T15:05:50Z

@mmusich @sroychow FYI

cmsbuild · 2020-05-12T16:40:59Z

+1
Tested at: 0421250
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0acf4/6251/summary.html
CMSSW: CMSSW_11_1_X_2020-05-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-12T16:41:02Z

Comparison job queued.

cmsbuild · 2020-05-12T18:08:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0acf4/6251/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2697527
DQMHistoTests: Total failures: 2039
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2695169
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2020-05-14T14:35:49Z

Jenkins tests are aborted.

jfernan2 · 2020-05-14T14:36:04Z

please test with #29826

cmsbuild · 2020-05-14T14:36:14Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #29826
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6304/console Started: 2020/05/14 16:36

sroychow · 2020-05-15T07:20:32Z

@jfernan2 the tests seem to be aborted again. Since #29826 is already merged, could you restart the test for this PR without asking it to be tested with 29826?

jfernan2 · 2020-05-15T08:10:54Z

please test

cmsbuild · 2020-05-15T08:11:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6329/console Started: 2020/05/15 10:12

cmsbuild · 2020-05-15T10:19:54Z

+1
Tested at: 29743a6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0acf4/6329/summary.html
CMSSW: CMSSW_11_1_X_2020-05-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-15T10:19:59Z

Comparison job queued.

cmsbuild · 2020-05-15T11:49:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0acf4/6329/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2696410
DQMHistoTests: Total failures: 348
DQMHistoTests: Total nulls: 402
DQMHistoTests: Total successes: 2695341
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -5095.211 KiB( 34 files compared)
DQMHistoSizes: changed ( 10024.0,... ): -311.156 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 1306.0,... ): -289.727 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 20034.0,... ): -289.332 KiB Tracking/TrackParameters
Checked 150 log files, 16 edm output root files, 35 DQM output files

jfernan2 · 2020-05-15T12:10:25Z

+1

SCAL disabled for RUN3
Black plots vs Lumi disabled for MC

cmsbuild · 2020-05-15T12:10:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-15T17:20:12Z

+1

cmsbuild added this to the CMSSW_11_1_X milestone May 12, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels May 12, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels May 12, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 12, 2020

cmsbuild added tests-started and removed tests-pending labels May 12, 2020

cmsbuild added tests-approved and removed tests-started labels May 12, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 12, 2020

cmsbuild added tests-started and removed tests-pending labels May 14, 2020

cmsbuild added tests-pending and removed tests-started labels May 15, 2020

cmsbuild added tests-started and removed requires-external tests-pending labels May 15, 2020

cmsbuild added tests-approved and removed tests-started labels May 15, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 15, 2020

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 15, 2020

cmsbuild added orp-approved and removed orp-pending labels May 15, 2020

cmsbuild merged commit 642f450 into cms-sw:master May 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace LumiScaler with OnlineMetaData for Run3 in TrackingDQM #29810

Replace LumiScaler with OnlineMetaData for Run3 in TrackingDQM #29810

arossi83 commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

jfernan2 commented May 12, 2020

cmsbuild commented May 12, 2020 •

edited

arossi83 commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 14, 2020

jfernan2 commented May 14, 2020

cmsbuild commented May 14, 2020 •

edited

sroychow commented May 15, 2020

jfernan2 commented May 15, 2020

cmsbuild commented May 15, 2020 •

edited

cmsbuild commented May 15, 2020

cmsbuild commented May 15, 2020

cmsbuild commented May 15, 2020

jfernan2 commented May 15, 2020

cmsbuild commented May 15, 2020

silviodonato commented May 15, 2020

Replace LumiScaler with OnlineMetaData for Run3 in TrackingDQM #29810

Replace LumiScaler with OnlineMetaData for Run3 in TrackingDQM #29810

Conversation

arossi83 commented May 12, 2020

PR description:

PR validation:

Not a Backport and no backport foreseen

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

jfernan2 commented May 12, 2020

cmsbuild commented May 12, 2020 • edited

arossi83 commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 14, 2020

jfernan2 commented May 14, 2020

cmsbuild commented May 14, 2020 • edited

sroychow commented May 15, 2020

jfernan2 commented May 15, 2020

cmsbuild commented May 15, 2020 • edited

cmsbuild commented May 15, 2020

cmsbuild commented May 15, 2020

cmsbuild commented May 15, 2020

jfernan2 commented May 15, 2020

cmsbuild commented May 15, 2020

silviodonato commented May 15, 2020

cmsbuild commented May 12, 2020 •

edited

cmsbuild commented May 14, 2020 •

edited

cmsbuild commented May 15, 2020 •

edited