ME0 migration to DD4HEP #29813

slomeo · 2020-05-12T15:48:11Z

PR description:

This PR is the same of the PR #29609 that was fully signed (by @cvuosalo , @perrotta , @kpedro88 ) but following the request of @silviodonato , in order to solve some conflict originated from #29632 (merged), I have decided to re-start with a new PR within a new IB. The PR #29609 will be closed asap.

This PR is related to the ME0 migration to DD4HEP
Only code Geometry migration, no alignment, no sensitive detectors

PR validation:

Made by ME0ValidateGeometryDD4hep_cfg.py and ME0ValidateGeomemtryOldDD_cfg.py.
see histos in Run3-gem36 Use MuonGeometryConstants rather than MuonDDDConstants #29632
runTheMatrix test ok with wf 18.0

cmsbuild · 2020-05-12T15:48:38Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-12T15:54:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29813/15319

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Geometry/python/GeometryDD4hepExtended2026D41_cff.py modified in PR(s): ME0 migration to DD4HEP #29609
- File Configuration/StandardSequences/python/DD4hep_GeometrySimPhase2_cff.py modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2026D41.xml modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometry/test/testME0Geometry_cfg.py modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/data/v10/GEMSpecs.xml modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/data/v10/GEMSpecsFilter.xml modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/plugins/BuildFile.xml modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/plugins/ME0GeometryESModule.cc modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/plugins/ME0GeometryValidate.cc modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/src/ME0GeometryBuilder.cc modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/src/ME0GeometryBuilder.h modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/src/ME0GeometryBuilderFromDDD.cc modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/src/ME0GeometryBuilderFromDDD.h modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/test/python/validateME0GeometryDD4hep_cfg.py modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/GEMGeometryBuilder/test/python/validateME0GeometryOldDD_cfg.py modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/MuonNumbering/interface/DD4hep_ME0NumberingScheme.h modified in PR(s): ME0 migration to DD4HEP #29609
- File Geometry/MuonNumbering/src/DD4hep_ME0NumberingScheme.cc modified in PR(s): ME0 migration to DD4HEP #29609
- File RecoLocalMuon/GEMRecHit/test/SingleMuPt100_cfi_GEM-SIM-DIGI_Extended2015MuonGEMDev.py modified in PR(s): ME0 migration to DD4HEP #29609

cmsbuild · 2020-05-12T15:55:11Z

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Configuration/Geometry
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/GEMGeometry
Geometry/GEMGeometryBuilder
Geometry/MuonNumbering
RecoLocalMuon/GEMRecHit

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @jhgoh, @VinInn, @jshlee, @bellan, @rovere, @lecriste, @dildick, @ptcox, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

slomeo · 2020-05-12T16:11:30Z

I closed #29609

kpedro88 · 2020-05-12T16:13:57Z

Geometry/GEMGeometryBuilder/plugins/BuildFile.xml

-  <lib name="Geom"/>
-  <use name="Geometry/GEMGeometryBuilder"/>
-  <flags EDM_PLUGIN="1"/>
+<use name="DetectorDescription/Core"/>


it looks like you undid the buildfile changes from the recent xml formatting pass, please revert

@kpedro88 : now "diff new_BuildFile.xml old_BuildFile.xml" is related only to the ME0 Validation part:

@kpedro88 : I restored the old format and I added only the ME0 validation part

cmsbuild · 2020-05-12T16:55:55Z

The code-checks are being triggered in jenkins.

silviodonato · 2020-05-12T16:59:27Z

please test
thanks @slomeo

cmsbuild · 2020-05-12T17:01:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29813/15320

This PR adds an extra 40KB to repository

cmsbuild · 2020-05-12T17:01:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6254/console Started: 2020/05/12 19:04

cmsbuild · 2020-05-12T17:01:32Z

Pull request #29813 was updated. @perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @slava77, @fabiocos, @davidlange6 can you please check and sign again.

cmsbuild · 2020-05-12T18:17:20Z

+1
Tested at: 1936f02
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab8a31/6254/summary.html
CMSSW: CMSSW_11_1_X_2020-05-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-12T18:17:23Z

Comparison job queued.

cmsbuild · 2020-05-12T20:01:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab8a31/6254/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2697527
DQMHistoTests: Total failures: 26
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2697182
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

perrotta · 2020-05-12T20:17:57Z

+1

Already signed as ME0 migration to DD4HEP #29609
Geometry related pull request: changes for reco are just technical, and involve the replacement of "ME0GeometryBuilderFromDDD" with "ME0GeometryBuilder" in a test script in RecoLocalMuon/GEMRecHit
Jenkins tests pass

kpedro88 · 2020-05-12T22:19:58Z

+upgrade

cvuosalo · 2020-05-13T00:04:58Z

+1

silviodonato · 2020-05-13T07:08:10Z

+operations

cmsbuild · 2020-05-13T07:08:34Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-13T07:12:21Z

+1

ME0 migration to DD4HEP

eb63f3a

cmsbuild added this to the CMSSW_11_1_X milestone May 12, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels May 12, 2020

slomeo mentioned this pull request May 12, 2020

ME0 migration to DD4HEP #29609

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels May 12, 2020

kpedro88 reviewed May 12, 2020

View reviewed changes

restored format BuildFile.xml

1936f02

cmsbuild added code-checks-pending and removed code-checks-approved labels May 12, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 12, 2020

cmsbuild removed the tests-pending label May 12, 2020

cmsbuild added the tests-started label May 12, 2020

cmsbuild added tests-approved and removed tests-started labels May 12, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 12, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels May 12, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels May 12, 2020

cmsbuild added geometry-approved and removed geometry-pending labels May 13, 2020

cmsbuild added fully-signed operations-approved and removed operations-pending pending-signatures labels May 13, 2020

cmsbuild added orp-approved and removed orp-pending labels May 13, 2020

cmsbuild merged commit 9fd0d32 into cms-sw:master May 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ME0 migration to DD4HEP #29813

ME0 migration to DD4HEP #29813

slomeo commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

slomeo commented May 12, 2020

kpedro88 May 12, 2020

slomeo May 12, 2020 •

edited

slomeo May 12, 2020

cmsbuild commented May 12, 2020

silviodonato commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020 •

edited

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

perrotta commented May 12, 2020

kpedro88 commented May 12, 2020

cvuosalo commented May 13, 2020

silviodonato commented May 13, 2020

cmsbuild commented May 13, 2020

silviodonato commented May 13, 2020

ME0 migration to DD4HEP #29813

ME0 migration to DD4HEP #29813

Conversation

slomeo commented May 12, 2020

PR description:

PR validation:

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

slomeo commented May 12, 2020

kpedro88 May 12, 2020

Choose a reason for hiding this comment

slomeo May 12, 2020 • edited

Choose a reason for hiding this comment

slomeo May 12, 2020

Choose a reason for hiding this comment

cmsbuild commented May 12, 2020

silviodonato commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020 • edited

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

cmsbuild commented May 12, 2020

perrotta commented May 12, 2020

kpedro88 commented May 12, 2020

cvuosalo commented May 13, 2020

silviodonato commented May 13, 2020

cmsbuild commented May 13, 2020

silviodonato commented May 13, 2020

slomeo May 12, 2020 •

edited

cmsbuild commented May 12, 2020 •

edited