Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SiPixelVCal DB object for pixel gain calibration #29829

Merged
merged 15 commits into from May 19, 2020

Conversation

IzaakWN
Copy link
Contributor

@IzaakWN IzaakWN commented May 13, 2020

PR description:

This new SiPixelVCal DB object is used for pixel gain calibration. The object saves a map between DetIDs (i.e. pixel modules) and VCal structs. The VCal struct only saves two floats: slope and offset to convert VCal to #electrons.

#electrons = slope * VCal + offset

Documentation is found in these slides:
https://indico.cern.ch/event/914013/#10-gain-calibration-for-run3-p

PR validation:

This code does not affect anything else inside CMSSW. It is only used for the pixel gain calibration in the independent DPGAnalysis-SiPixelTools repository.

The code compiles and works as expected, for example to create and read a .db file (see the above slides).

@cmsbuild cmsbuild changed the base branch from CMSSW_11_1_X to master May 13, 2020 17:46
@cmsbuild
Copy link
Contributor

@IzaakWN, CMSSW_11_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29829/15357

  • This PR adds an extra 124KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29829/15358

  • This PR adds an extra 128KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29829/15475

  • This PR adds an extra 148KB to repository

@cmsbuild
Copy link
Contributor

Pull request #29829 was updated. @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented May 18, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6389/console Started: 2020/05/18 14:52

@cmsbuild
Copy link
Contributor

+1
Tested at: b05e06a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ee259/6389/summary.html
CMSSW: CMSSW_11_1_X_2020-05-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ee259/6389/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694369
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@pohsun
Copy link

pohsun commented May 18, 2020

+1

@ggovi
Copy link
Contributor

ggovi commented May 19, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants