New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SiPixelVCal DB object for pixel gain calibration #29829
Conversation
@IzaakWN, CMSSW_11_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29829/15357
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29829/15358
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29829/15475
|
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This new
SiPixelVCal DB
object is used for pixel gain calibration. The object saves a map betweenDetID
s (i.e. pixel modules) andVCal
structs. TheVCal
struct only saves two floats: slope and offset to convert VCal to #electrons.Documentation is found in these slides:
https://indico.cern.ch/event/914013/#10-gain-calibration-for-run3-p
PR validation:
This code does not affect anything else inside CMSSW. It is only used for the pixel gain calibration in the independent DPGAnalysis-SiPixelTools repository.
The code compiles and works as expected, for example to create and read a
.db
file (see the above slides).