Clean BuildFiles in Cond subsystems

[guitargeek]

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #29805), this time covering all Cond subsystems.

I checked that all the BuildFiles are still well formatted, to not undo any work done by the formatting PRs a few days ago.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29906/15498

• This PR adds an extra 80KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiPixelESProducers/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File CondCore/SiPixelPlugins/test/BuildFile.xml modified in PR(s): [Payload Inspector] Add more SiPixel inspection classes #29864
  • File CondTools/BeamSpot/plugins/BuildFile.xml modified in PR(s): New BeamSpot Object and Records #29662

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CalibTracker/SiPixelConnectivity
CalibTracker/SiPixelESProducers
CalibTracker/SiPixelLorentzAngle
CalibTracker/SiPixelQuality
CalibTracker/SiStripCommon
CondCore/AlignmentPlugins
CondCore/BTauPlugins
CondCore/BeamSpotPlugins
CondCore/CSCPlugins
CondCore/CTPPSPlugins
CondCore/CalibPlugins
CondCore/CastorPlugins
CondCore/CondDB
CondCore/DBOutputService
CondCore/DQMPlugins
CondCore/DTPlugins
CondCore/ESPlugins
CondCore/ESSources
CondCore/EcalPlugins
CondCore/EgammaPlugins
CondCore/GEMPlugins
CondCore/GeometryPlugins
CondCore/HIPlugins
CondCore/HLTPlugins
CondCore/HcalPlugins
CondCore/L1TPlugins
CondCore/OptAlignPlugins
CondCore/PCLConfigPlugins
CondCore/PhysicsToolsPlugins
CondCore/PopCon
CondCore/RPCPlugins
CondCore/RecoMuonPlugins
CondCore/RunInfoPlugins
CondCore/SiPhase2TrackerPlugins
CondCore/SiPixelPlugins
CondCore/SiStripPlugins
CondCore/Utilities
CondFormats/Alignment
CondFormats/BTauObjects
CondFormats/BeamSpotObjects
CondFormats/Common
CondFormats/DTObjects
CondFormats/EcalCorrections
CondFormats/EcalObjects
CondFormats/EgammaObjects
CondFormats/GEMObjects
CondFormats/GeometryObjects
CondFormats/HIObjects
CondFormats/HLTObjects
CondFormats/HcalObjects
CondFormats/JetMETObjects
CondFormats/L1TObjects
CondFormats/MFObjects
CondFormats/OptAlignObjects
CondFormats/PCLConfig
CondFormats/PhysicsToolsObjects
CondFormats/RecoMuonObjects
CondFormats/RunInfo
CondFormats/SiPhase2TrackerObjects
CondFormats/SiPixelObjects
CondFormats/SiPixelTransient
CondFormats/SiStripObjects
CondTools/BTau
CondTools/BeamSpot
CondTools/CTPPS
CondTools/DQM
CondTools/DT
CondTools/Ecal
CondTools/Geometry
CondTools/Hcal
CondTools/L1Trigger
CondTools/L1TriggerExt
CondTools/RPC
CondTools/RunInfo
CondTools/SiPhase2Tracker
CondTools/SiPixel
CondTools/Utilities
GeometryReaders/XMLIdealGeometryESSource

@andrius-k, @schneiml, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @fioriNTU, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @fwyzard, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @benkrikler, @kmaeshima, @christopheralanwest can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @echabert, @forthommel, @pieterdavid, @robervalwalsh, @emilbols, @argiro, @jshlee, @threus, @seemasharmafnal, @mmarionncern, @battibass, @ahinzmann, @smoortga, @jdolen, @ferencek, @tocheng, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mmusich, @abdoulline, @fabiocos, @clelange, @rchatter, @gbenelli, @JyothsnaKomaragiri, @mverzett, @dkotlins, @mariadalfonso, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6420/console Started: 2020/05/19 15:01

[cmsbuild]

-1

Tested at: aab6923

CMSSW: CMSSW_11_1_X_2020-05-18-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3398da/6420/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

[cmsbuild]

Comparison job queued.

[guitargeek]

It's strange that this one unit test failed, here is the error message:

----- Begin Fatal Exception 19-May-2020 17:23:43 CEST-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
Module run order problem found: 
rawDataCollector consumes gmtStage2Raw, gmtStage2Raw consumes simEmtfDigis, simEmtfDigis consumes rpcRecHits, rpcRecHits consumes muonRPCDigis, muonRPCDigis consumes rawDataCollector
 Running in the threaded framework would lead to indeterminate results.
 Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.
----- End Fatal Exception -------------------------------------------------

At first glance I don't see how this can possible relate to cleaning up the BuildFiles....

[pohsun]

+1

[santocch]

+1

[Martin-Grunewald]

+1

[silviodonato]

Do you have any comments?
db: @ggovi
l1: @benkrikler @rekovic
I would merge it in the next IB

[rekovic]

+1

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1