Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings from ONNXRuntime #29989

Merged
merged 1 commit into from May 28, 2020
Merged

Suppress warnings from ONNXRuntime #29989

merged 1 commit into from May 28, 2020

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented May 26, 2020

Change ONNXRuntime logging level to ORT_LOGGING_LEVEL_ERROR.
This should fix cms-sw/cmsdist#5857 (comment).

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29989/15661

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms (Huilin Qu) for master.

It involves the following packages:

PhysicsTools/ONNXRuntime

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented May 26, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 26, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5857
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6598/console Started: 2020/05/26 18:37

@cmsbuild
Copy link
Contributor

-1

Tested at: 1978626

CMSSW: CMSSW_11_2_X_2020-05-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef7ee4/6598/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef7ee4/6598/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef7ee4/6598/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/FunctionChecker.cpp
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/GlobalStaticChecker.cpp
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/FunctionDumper.cpp
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc: In member function 'void clangcms::FiniteMathChecker::checkPreStmt(const clang::CallExpr*, clang::ento::CheckerContext&) const':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:40:34: error: 'PathSensitiveBugReport' is not a member of 'clang::ento'
     std::unique_ptr PSBR =
                                  ^~~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:40:56: error: template argument 1 is invalid
     std::unique_ptr PSBR =
                                                        ^

  • Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/ArgSizeChecker.cpp
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/CatchAll.cpp
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/ClangCmsCheckerPluginRegister.cpp
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/ClassChecker.cpp
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/ClassDumper.cpp
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/ArgSizeChecker.cpp:104:27: error: use of undeclared identifier 'BasicBugReport'
          std::unique_ptr report =
                          ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-05-26-1100/src/Utilities/StaticAnalyzers/src/ArgSizeChecker.cpp:104:43: error: C++ requires a type specifier for all declarations
          std::unique_ptr report =
                                          ^


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef7ee4/6598/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef7ee4/6598/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@mrodozov
Copy link
Contributor

@slava77 I think we broke the IB with the last LLVM update somehow :/

@slava77
Copy link
Contributor

slava77 commented May 26, 2020

@slava77 I think we broke the IB with the last LLVM update somehow :/

OK, thanks for reminding,
is the fix expected in CMSSW_11_2_X_2020-05​-26-1700 ?

@smuzaffar
Copy link
Contributor

yes 17h IB should be good for tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 26, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5857
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6602/console Started: 2020/05/26 23:55

@cmsbuild
Copy link
Contributor

+1
Tested at: 1978626
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac6d24/6602/summary.html
CMSSW: CMSSW_11_2_X_2020-05-26-1700
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac6d24/6602/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 73
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780669
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@slava77
Copy link
Contributor

slava77 commented May 27, 2020

+1

for #29989 1978626

this PR can be merged by itself

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants