Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Test clang-tidy --checks modernize-make-unique #29934

Closed
wants to merge 2 commits into from
Closed

[RFC] Test clang-tidy --checks modernize-make-unique #29934

wants to merge 2 commits into from

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 21, 2020

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 21, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard fwyzard mentioned this pull request May 21, 2020
Closed
This was referenced May 21, 2020
Merged
Closed
Closed
Closed
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29934/15548

Code check has found code style and quality issues which could be resolved by applying following patch(s)

This was referenced Jun 29, 2020
Merged
Merged
Merged
Merged
@mrodozov
Copy link
Contributor

-note
have it and have a patch for mac release of fireworks

@alja
Copy link
Contributor

alja commented Jun 30, 2020

+1

Martin-Grunewald
Martin-Grunewald reviewed Jul 1, 2020
View reviewed changes
HLTrigger/HLTanalyzers/plugins/HLTInfo.h
@@ -109,7 +111,7 @@ HLTInfo::HLTInfo(edm::ParameterSet const& pset, edm::ConsumesCollector&& iC, T&

template <typename T>
HLTInfo::HLTInfo(edm::ParameterSet const& pset, edm::ConsumesCollector& iC, T& module) : HLTInfo() {
hltPrescaleProvider_.reset(new HLTPrescaleProvider(pset, iC, module));
hltPrescaleProvider_ = std::make_unique<HLTPrescaleProvider>(pset, iC, module);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the call to method reset()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset() releases the old pointed-to object and takes ownership of a new one; assigning a new unique_ptr has the same effect

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks...

@Martin-Grunewald
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 1, 2020

+upgrade
(philosophically)

@mrodozov mrodozov mentioned this pull request Jul 2, 2020
Closed
This was referenced Jul 6, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Jul 13, 2020
Merged
Merged
Merged
Merged
@fwyzard fwyzard closed this Jul 14, 2020
@fwyzard fwyzard deleted the clang-tidy-modernize-make-unique branch July 14, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianna ianna ianna left review comments

@Martin-Grunewald Martin-Grunewald Martin-Grunewald left review comments

Assignees
No one assigned
Labels
alca-approved analysis-approved code-checks-approved comparison-available core-pending daq-approved db-pending dqm-approved fastsim-approved generators-approved geometry-approved hlt-approved l1-pending orp-pending pending-signatures reconstruction-approved simulation-approved tests-approved upgrade-approved visualization-approved xpog-pending
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet