Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RECONSTRUCTION] fixes UBSAN build errors #30020

Merged
merged 2 commits into from May 29, 2020
Merged

[RECONSTRUCTION] fixes UBSAN build errors #30020

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
588b8b5
[RECONSTRUCTION] fixes UBSAN build errors
smuzaffar May 28, 2020
5dc9de9
removed the duplicate deps
smuzaffar May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions DataFormats/JetReco/BuildFile.xml
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@
<use name="DataFormats/ParticleFlowReco"/>
<use name="DataFormats/TrackReco"/>
<use name="FWCore/Utilities"/>
<use name="DataFormats/Candidate"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the UBSAN IBs log you are pointing at in the PR description I was able to find the build errors that require the updates you are proposing for the other three BuildFile's, but not for this one.

For my own understending, could you please point me to the error in the log that suggests adding "DataFormats/Candidate" here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue was that DQMOffline/Alignment had build error [a] but I noticed that it is getting LeafCandidate via DataFormats/JetReco with out dependency in BuildFile[b]. So I added the required dependency for DQMOffline/Alignment ( https://github.com/cms-sw/cmssw/pull/30023/files#diff-f6befb70f0da8d2364ca45ff83e014a4R7 ) but error was still not fixed. Then I noticed that DataFormats/JetReco uses DataFormats/Candidate without explicit dep in BuildFile. That is why I proposed this change.

[a]
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_UBSAN_X_2020-05-22-2300/DQMOffline/Alignment

undefined reference to `typeinfo for reco::LeafCandidate'

[b]

DQMOffline/Alignment/interface/TkAlCaRecoMonitor.h:#include <DataFormats/JetReco/interface/CaloJet.h>

Copy link
Contributor Author

@smuzaffar smuzaffar May 29, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad here, looks like DataFormats/JetReco already has the right deps. I will revert this change. please hold

<flags LCG_DICT_HEADER="classes_1.h classes_2.h classes_3.h classes_4.h"/>
<flags LCG_DICT_XML="classes_def_1.xml classes_def_2.xml classes_def_3.xml classes_def_4.xml"/>
<export>
Expand Down
1 change: 1 addition & 0 deletions RecoHI/HiTracking/test/BuildFile.xml
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@
<use name="Geometry/CommonDetUnit"/>
<use name="Geometry/Records"/>
<use name="Geometry/TrackerGeometryBuilder"/>
<use name="DataFormats/TrackReco"/>
<library file="*.cc" name="RecoHIHiTrackingTest">
<flags EDM_PLUGIN="1"/>
</library>
1 change: 1 addition & 0 deletions RecoLocalMuon/CSCValidation/BuildFile.xml
View file
Open in desktop
Expand Up @@ -8,6 +8,7 @@
<use name="DataFormats/CSCRecHit"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/MuonDetId"/>
<use name="DataFormats/TrackReco"/>
<use name="CondFormats/CSCObjects"/>
<use name="root"/>
<use name="rootcore"/>
Expand Down
1 change: 1 addition & 0 deletions RecoMuon/MuonIdentification/BuildFile.xml
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@
<use name="DataFormats/MuonDetId"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/RPCRecHit"/>
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
Expand Down