[RECONSTRUCTION] fixes UBSAN build errors #30020

smuzaffar · 2020-05-28T17:01:12Z

Added missing dependencies to avoid UBSAN IBs build errors

https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc7_amd64_gcc820/www/fri/11.2.UBSAN-fri-23/CMSSW_11_2_UBSAN_X_2020-05-22-2300

cmsbuild · 2020-05-28T17:01:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-28T17:06:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30020/15712

This PR adds an extra 16KB to repository

cmsbuild · 2020-05-28T17:06:29Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/JetReco
RecoHI/HiTracking
RecoLocalMuon/CSCValidation
RecoMuon/MuonIdentification

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @abbiendi, @echapon, @jazzitup, @seemasharmafnal, @ahinzmann, @jhgoh, @jdolen, @HuguesBrun, @cericeci, @ptcox, @trocino, @rociovilar, @rovere, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @dgulhan, @clelange, @mandrenguyen, @Fedespring, @calderona, @yenjie, @kurtejung, @mariadalfonso, @yetkinyilmaz, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2020-05-28T17:07:53Z

please test

cmsbuild · 2020-05-28T17:08:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6655/console Started: 2020/05/28 19:13

cmsbuild · 2020-05-28T19:36:19Z

+1
Tested at: 588b8b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27c098/6655/summary.html
CMSSW: CMSSW_11_2_X_2020-05-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-28T19:36:22Z

Comparison job queued.

cmsbuild · 2020-05-28T21:10:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27c098/6655/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2780792
DQMHistoTests: Total failures: 43
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2780699
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

perrotta · 2020-05-29T07:32:01Z

DataFormats/JetReco/BuildFile.xml

@@ -6,6 +6,7 @@
 <use name="DataFormats/ParticleFlowReco"/>
 <use name="DataFormats/TrackReco"/>
 <use name="FWCore/Utilities"/>
+<use name="DataFormats/Candidate"/>


Looking at the UBSAN IBs log you are pointing at in the PR description I was able to find the build errors that require the updates you are proposing for the other three BuildFile's, but not for this one.

For my own understending, could you please point me to the error in the log that suggests adding "DataFormats/Candidate" here?

I think the issue was that DQMOffline/Alignment had build error [a] but I noticed that it is getting LeafCandidate via DataFormats/JetReco with out dependency in BuildFile[b]. So I added the required dependency for DQMOffline/Alignment ( https://github.com/cms-sw/cmssw/pull/30023/files#diff-f6befb70f0da8d2364ca45ff83e014a4R7 ) but error was still not fixed. Then I noticed that DataFormats/JetReco uses DataFormats/Candidate without explicit dep in BuildFile. That is why I proposed this change.

[a]
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_UBSAN_X_2020-05-22-2300/DQMOffline/Alignment

undefined reference to `typeinfo for reco::LeafCandidate'

[b]

DQMOffline/Alignment/interface/TkAlCaRecoMonitor.h:#include <DataFormats/JetReco/interface/CaloJet.h>

my bad here, looks like DataFormats/JetReco already has the right deps. I will revert this change. please hold

cmsbuild · 2020-05-29T08:18:15Z

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

smuzaffar · 2020-05-29T08:20:45Z

please test

cmsbuild · 2020-05-29T08:20:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-29T08:29:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30020/15744

This PR adds an extra 16KB to repository

cmsbuild · 2020-05-29T08:29:54Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6682/console Started: 2020/05/29 10:37

cmsbuild · 2020-05-29T08:29:55Z

Pull request #30020 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

cmsbuild · 2020-05-29T09:53:54Z

+1
Tested at: 5dc9de9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27c098/6682/summary.html
CMSSW: CMSSW_11_2_X_2020-05-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-29T09:53:57Z

Comparison job queued.

cmsbuild · 2020-05-29T11:31:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27c098/6682/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2780792
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2780740
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

perrotta · 2020-05-29T11:59:39Z

+1

Technical
Jenkins tests pass

cmsbuild · 2020-05-29T12:00:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-29T14:02:16Z

+1

[RECONSTRUCTION] fixes UBSAN build errors

588b8b5

cmsbuild added this to the CMSSW_11_2_X milestone May 28, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 28, 2020

cmsbuild added tests-started and removed tests-pending labels May 28, 2020

cmsbuild added tests-approved and removed tests-started labels May 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 28, 2020

perrotta reviewed May 29, 2020

View reviewed changes

cmsbuild added the hold label May 29, 2020

removed the duplicate deps

5dc9de9

cmsbuild removed the code-checks-approved label May 29, 2020

cmsbuild added code-checks-pending comparison-pending tests-pending labels May 29, 2020

cmsbuild removed the hold label May 29, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 29, 2020

cmsbuild added tests-started and removed tests-pending labels May 29, 2020

cmsbuild added tests-approved and removed tests-started labels May 29, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 29, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels May 29, 2020

cmsbuild added orp-approved and removed orp-pending labels May 29, 2020

cmsbuild merged commit ed4b778 into cms-sw:master May 29, 2020

slava77 mentioned this pull request Jul 7, 2020

Clean BuildFiles in reco plugins #30535

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RECONSTRUCTION] fixes UBSAN build errors #30020

[RECONSTRUCTION] fixes UBSAN build errors #30020

smuzaffar commented May 28, 2020 •

edited

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

smuzaffar commented May 28, 2020

cmsbuild commented May 28, 2020 •

edited

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

perrotta May 29, 2020

smuzaffar May 29, 2020

smuzaffar May 29, 2020 •

edited

cmsbuild commented May 29, 2020

smuzaffar commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020 •

edited

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

perrotta commented May 29, 2020

cmsbuild commented May 29, 2020

silviodonato commented May 29, 2020

[RECONSTRUCTION] fixes UBSAN build errors #30020

[RECONSTRUCTION] fixes UBSAN build errors #30020

Conversation

smuzaffar commented May 28, 2020 • edited

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

smuzaffar commented May 28, 2020

cmsbuild commented May 28, 2020 • edited

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

perrotta May 29, 2020

Choose a reason for hiding this comment

smuzaffar May 29, 2020

Choose a reason for hiding this comment

smuzaffar May 29, 2020 • edited

Choose a reason for hiding this comment

cmsbuild commented May 29, 2020

smuzaffar commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020 • edited

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

perrotta commented May 29, 2020

cmsbuild commented May 29, 2020

silviodonato commented May 29, 2020

smuzaffar commented May 28, 2020 •

edited

cmsbuild commented May 28, 2020 •

edited

smuzaffar May 29, 2020 •

edited

cmsbuild commented May 29, 2020 •

edited