optimize: rely on Candidate pt,eta,phi without casting in MuonPFIsolationWithConeVeto

[slava77]

visual optimization based on https://jiwoong.web.cern.ch/jiwoong/cgi-bin/igprof-navigator/igprofCPU_CMSSW_11_1_0_pre8PAT/28

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

ERROR: Build errors found during clang-tidy run.

PhysicsTools/IsolationAlgos/plugins/CITKPFIsolationSumProducerForPUPPI.cc:148:87: error: no viable overloaded '=' [clang-diagnostic-error]
            if (!useValueMapForPUPPI && aspackedCandidate.isNull()) aspackedCandidate = isocand;
                                                                                      ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-05-29-2300/src/DataFormats/Common/interface/Ptr.h:40:9: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'Ptr<reco::Candidate>' to 'const Ptr<pat::PackedCandidate>' for 1st argument
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30054/15764

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30054/15764/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30054/15764/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30054/15766

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30054/15766/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30054/15766/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30054/15768

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

PhysicsTools/IsolationAlgos
RecoMuon/MuonIsolation

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @Fedespring, @echapon, @calderona, @HuguesBrun, @jhgoh, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6701/console Started: 2020/05/30 04:46

[cmsbuild]

+1
Tested at: a4a7812
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af84ce/6701/summary.html
CMSSW: CMSSW_11_2_X_2020-05-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af84ce/6701/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780741
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[slava77]

+1

for #30054 a4a7812

• jenkins tests show no differences as expected
• local test with 136.88811 shows about a factor of 2.7 speedup in muonPUPPINoLeptonsIsolation and muonPUPPIIsolation modules (still barely 0.1% improvement in this run2 workflow; the impact should be much larger in phase-2, around 5-7% speedup expected per job in PU200 miniAOD)

[silviodonato]

merge
cc: @santocch , technical change, no change in physics

[slava77]

just for completeness, since the optimization was focused on phase-2 workflow profiling:

• on wf 23434.21 step4 (ttbar PU200 miniAOD) the speedup is 8% of the total job time

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.