Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move calorimeter calibration DQM modules back to Sequences #30086

Merged
merged 2 commits into from Jun 4, 2020

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jun 2, 2020

PR description:

This PR is a follow-up to #29630 and reverts the changes made to ECAL and HCAL calibration DQM modules by moving them back to Sequences, i.e. to be run only if the preceding filters keep processing the event.

PR validation:

Limited matrix runs, expecting changes in ECAL and ECAL AlcaReco DQM.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30086/15823

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Configuration/StandardSequences

@silviodonato, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tocheng, @lecriste, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Jun 2, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6755/console Started: 2020/06/02 23:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

+1
Tested at: f5632c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14012d/6755/summary.html
CMSSW: CMSSW_11_2_X_2020-06-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14012d/6755/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2783666
  • DQMHistoTests: Total failures: 56
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 2783558
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.055 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.020 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1000.0 ): 0.020 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.53,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 140.53,... ): 0.004 KiB MessageLogger/Errors
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@pohsun
Copy link

pohsun commented Jun 4, 2020

+1

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a1964c4 into cms-sw:master Jun 4, 2020
@makortel makortel deleted the dqmCalo branch June 4, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants