Run3 hcx259: Change names of classes which are not dependent on DDD/DD4Hep package

[bsunanda]

PR description:

Change names of classes which are not dependent on DDD/DD4Hep package

PR validation:

Tested using runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing speical

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30118/15884

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FastSimulation/ShowerDevelopment/src/FastHFShowerLibrary.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File SimG4CMS/Calo/src/HCalSD.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks performance-for-range-copy #29927
  • File SimG4CMS/ShowerLibraryProducer/src/FiberSD.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
FastSimulation/ShowerDevelopment
Geometry/HcalCommonData
SimG4CMS/Calo
SimG4CMS/ShowerLibraryProducer

@ssekmen, @Dr15Jones, @lveldere, @makortel, @cvuosalo, @civanch, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @sbein can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @rovere, @Martin-Grunewald, @matt-komm, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6831/console Started: 2020/06/05 00:04

[cmsbuild]

+1
Tested at: 40602a7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ecca5/6831/summary.html
CMSSW: CMSSW_11_2_X_2020-06-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ecca5/6831/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2783960
• DQMHistoTests: Total failures: 30
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2783880
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[cvuosalo]

Thanks for the clean-up!

[cvuosalo]

+1

[civanch]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1