Reduce boost in Fireworks/Core #30165

camolezi · 2020-06-09T21:17:50Z

PR description:

Replaced boost library use for C++ STL alternatives. Replaced boost::function for std::function and boost::bind for std::bind. The code should have similar behavior.

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

cmsbuild · 2020-06-09T21:18:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-09T21:23:42Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30165/15966

This PR adds an extra 164KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Fireworks/Core/interface/FWGUIManager.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Fireworks/Core/src/CmsShowCommon.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowCommonPopup.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowEDI.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowMain.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File Fireworks/Core/src/CmsShowMainBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File Fireworks/Core/src/CmsShowModelPopup.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowNavigator.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowViewPopup.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FW3DViewBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWCollectionSummaryTableManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWColorSelect.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWConfiguration.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWDetailViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWEveView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWEveViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Fireworks/Core/src/FWEventItemsManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWFileEntry.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGUIEventDataAdder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGUIManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGeometryTableManagerBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGeometryTableView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGeometryTableViewBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWGeometryTableViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Fireworks/Core/src/FWGlimpseView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWLegoViewBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWOverlapTableView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWParameterSetterBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWProxyBuilderBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWProxyBuilderConfiguration.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWRPZView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWSelectionManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWSummaryManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWTableViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWTriggerTableView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWTriggerTableViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWViewEnergyScale.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Fireworks/Core/src/FWViewGeometryList.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Fireworks/Core/src/FWViewManagerManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30165/15966/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30165/15966/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-06-09T21:40:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-09T21:49:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30165/15967

This PR adds an extra 164KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Fireworks/Core/interface/FWGUIManager.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Fireworks/Core/src/CmsShowCommon.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowCommonPopup.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowEDI.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowMain.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File Fireworks/Core/src/CmsShowMainBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File Fireworks/Core/src/CmsShowModelPopup.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowNavigator.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/CmsShowViewPopup.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FW3DViewBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWCollectionSummaryTableManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWColorSelect.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWConfiguration.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWDetailViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWEveView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWEveViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Fireworks/Core/src/FWEventItemsManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWFileEntry.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGUIEventDataAdder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGUIManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGeometryTableManagerBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGeometryTableView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWGeometryTableViewBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWGeometryTableViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Fireworks/Core/src/FWGlimpseView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWLegoViewBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWOverlapTableView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWParameterSetterBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWProxyBuilderBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWProxyBuilderConfiguration.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWRPZView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWSelectionManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWSummaryManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWTableViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWTriggerTableView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File Fireworks/Core/src/FWTriggerTableViewManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File Fireworks/Core/src/FWViewEnergyScale.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File Fireworks/Core/src/FWViewGeometryList.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Fireworks/Core/src/FWViewManagerManager.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

cmsbuild · 2020-06-09T21:50:00Z

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

Fireworks/Core

@makortel, @cmsbuild, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

davidlange6 · 2020-06-10T12:49:18Z

please test

cmsbuild · 2020-06-10T12:49:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6932/console Started: 2020/06/10 14:50

cmsbuild · 2020-06-10T13:09:37Z

+1
Tested at: 75a1f51
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06da38/6932/summary.html
CMSSW: CMSSW_11_2_X_2020-06-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-10T13:09:39Z

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

alja · 2020-06-10T18:38:53Z

+1
@camolezi
Thank you for replacing boost bindings with std. Did you made a test of changes?
If not, I can make them after integration build.

cmsbuild · 2020-06-10T18:39:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

camolezi · 2020-06-10T19:04:24Z

+1
@camolezi
Thank you for replacing boost bindings with std. Did you made a test of changes?
If not, I can make them after integration build.

I only ran the runTheMatrix test.

silviodonato · 2020-06-10T19:44:26Z

+1

replaced boost::function for std::function

26a50d0

cmsbuild added this to the CMSSW_11_2_X milestone Jun 9, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures tests-pending visualization-pending labels Jun 9, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 9, 2020

replaced boost::bind for std::bind

75a1f51

camolezi force-pushed the reduce-boost-bind-clang-tidy branch from 60498f2 to 75a1f51 Compare June 9, 2020 21:40

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 9, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 9, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 10, 2020

cmsbuild added comparison-notrun and removed comparison-pending tests-started labels Jun 10, 2020

cmsbuild added the tests-approved label Jun 10, 2020

cmsbuild added fully-signed and removed pending-signatures visualization-pending labels Jun 10, 2020

cmsbuild added the visualization-approved label Jun 10, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 10, 2020

cmsbuild merged commit 575b8f2 into cms-sw:master Jun 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce boost in Fireworks/Core #30165

Reduce boost in Fireworks/Core #30165

camolezi commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

davidlange6 commented Jun 10, 2020

cmsbuild commented Jun 10, 2020 •

edited

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

alja commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

camolezi commented Jun 10, 2020

silviodonato commented Jun 10, 2020

Reduce boost in Fireworks/Core #30165

Reduce boost in Fireworks/Core #30165

Conversation

camolezi commented Jun 9, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

davidlange6 commented Jun 10, 2020

cmsbuild commented Jun 10, 2020 • edited

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

alja commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

camolezi commented Jun 10, 2020

silviodonato commented Jun 10, 2020

cmsbuild commented Jun 10, 2020 •

edited