Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for L1 tracking algorithm (bug fixes) #30168

Merged
merged 7 commits into from Jun 30, 2020

Conversation

skinnari
Copy link
Contributor

This PR contains fixes for the L1 tracking for the HLT TDR:

(1) The update restores the expected pt resolution for high-pt particles (a bug had been introduced during the CMSSW integration).
(2) It allows to run the displaced ("extended") version of the L1 tracking w/o having to be in a particular directory (using edm::fileInPath), to make sure it could run in central production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 10, 2020

A new Pull Request was created by @skinnari (Louise Skinnari) for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/TrackFindingTracklet

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Jun 10, 2020

@skinnari could you make a PR for CMSSW_11_2_X as well ?

@fwyzard
Copy link
Contributor

fwyzard commented Jun 10, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 10, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6920/console Started: 2020/06/10 08:36

@cmsbuild
Copy link
Contributor

+1
Tested at: c7d093c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56b3f5/6920/summary.html
CMSSW: CMSSW_11_1_X_2020-06-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56b3f5/6920/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780693
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@skinnari
Copy link
Contributor Author

@skinnari could you make a PR for CMSSW_11_2_X as well ?

hi @fwyzard apologies, I missed the request to make a separate PR also to CMSSW_11_2_X. this is now available through PR #30245.

@fwyzard
Copy link
Contributor

fwyzard commented Jun 15, 2020

type bugfix

@fwyzard
Copy link
Contributor

fwyzard commented Jun 15, 2020

backport #30245

@silviodonato
Copy link
Contributor

assign upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

Pull request #30168 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again.

cmsbuild added a commit that referenced this pull request Jun 29, 2020
Update of L1 tracking (matching PR #30168)
@silviodonato
Copy link
Contributor

@kpedro88 @rekovic I think can we merge this backport, can't we?

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 30, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: e9a946c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56b3f5/7526/summary.html
CMSSW: CMSSW_11_1_X_2020-06-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56b3f5/7526/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 84b1d6c into cms-sw:CMSSW_11_1_X Jun 30, 2020
@skinnari skinnari deleted the L1TK_9june2020 branch July 1, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants