Update of L1 tracking (matching PR #30168) #30245

skinnari · 2020-06-15T14:23:36Z

This is an identical update as PR #30168 (for reference, description below) but to CMSSW_11_2_X instead of CMSSW_11_1_X .

This PR contains fixes for the L1 tracking for the HLT TDR:

(1) The update restores the expected pt resolution for high-pt particles (a bug had been introduced during the CMSSW integration).
(2) It allows to run the displaced ("extended") version of the L1 tracking w/o having to be in a particular directory (using edm::fileInPath), to make sure it could run in central production.

cmsbuild · 2020-06-15T14:24:04Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-06-15T14:26:53Z

type bugfix

fwyzard · 2020-06-15T14:27:08Z

@cmsbuild, please test

cmsbuild · 2020-06-15T14:28:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30245/16138

This PR adds an extra 100KB to repository

silviodonato · 2020-06-15T14:29:12Z

assign upgrade

cmsbuild · 2020-06-15T14:29:19Z

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2020-06-15T14:29:21Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-14-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7072/console Started: 2020/06/15 16:35

cmsbuild · 2020-06-15T14:29:22Z

A new Pull Request was created by @skinnari (Louise Skinnari) for master.

It involves the following packages:

L1Trigger/TrackFindingTracklet

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

silviodonato · 2020-06-15T14:30:05Z

urgent

cmsbuild · 2020-06-15T15:48:19Z

+1
Tested at: 03ce8d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c625ae/7072/summary.html
CMSSW: CMSSW_11_2_X_2020-06-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-15T15:48:22Z

Comparison job queued.

cmsbuild · 2020-06-29T17:07:06Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30325,#30458

CMSSW_11_2_X_2020-06-29-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7502/console Started: 2020/06/29 21:51

cmsbuild · 2020-06-29T21:45:49Z

-1
@skinnari This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30245/7502/git-merge-result

cmsbuild · 2020-06-30T09:19:36Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30325,#30458

CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7513/console Started: 2020/06/30 11:30

cmsbuild · 2020-06-30T09:47:14Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30325,#30458

CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7514/console Started: 2020/06/30 11:49

skinnari · 2020-06-30T10:14:48Z

-1
@skinnari This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30245/7502/git-merge-result

just to be sure - there was a message overnight that I needed to rebase for it to be able to be merged, but it seems here that it is listed as "merged". do I need to rebase or not?

silviodonato · 2020-06-30T10:24:37Z

@skinnari the message was related to another PR. We tested several PRs together, the test failed because there was a conflict between two of them, and then the message was sent to the author of each PR. In short, please ignore that message.

cmsbuild · 2020-06-30T11:54:13Z

+1
Tested at: 8d7dd5d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/summary.html
CMSSW: CMSSW_11_2_X_2020-06-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

added esConsumes to modules in RecoLocalMuon/GEMSegment #30451 @JamminJones: added esConsumes to modules in RecoLocalMuon/GEMSegment
added esConsumes to modules in RecoLocalMuon/GEMRecHit #30450 @JamminJones: added esConsumes to modules in RecoLocalMuon/GEMRecHit
Revert "Run4-hgx247 Add some new features for HGCal" #30458 @cms-sw: Revert "Run4-hgx247 Add some new features for HGCal"

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/git-merge-result

cmsbuild · 2020-06-30T11:54:26Z

Comparison job queued.

cmsbuild · 2020-06-30T13:46:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7514/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778915
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778864
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

cmsbuild · 2020-07-01T09:10:23Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30363,cms-data/L1Trigger-L1TCalorimeter#22,cms-data/L1Trigger-L1TMuon#18,#30325,#30458

CMSSW_11_2_X_2020-06-30-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7551/console Started: 2020/07/01 11:13

cmsbuild · 2020-07-01T11:02:54Z

+1
Tested at: 8d7dd5d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7551/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-01T11:03:08Z

Comparison job queued.

cmsbuild · 2020-07-01T13:23:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a912c/7551/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2784064
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 154 log files, 17 edm output root files, 37 DQM output files

skinnari added 3 commits June 15, 2020 16:10

bug fix + improvement for displaced tracking

bffd525

code formats

2cbd267

propagate fix to pick up stubs on triplet seeds in chi2 fit

03ce8d1

cmsbuild added this to the CMSSW_11_2_X milestone Jun 15, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Jun 15, 2020

skinnari mentioned this pull request Jun 15, 2020

Update for L1 tracking algorithm (bug fixes) #30168

Merged

cmsbuild added the bug-fix label Jun 15, 2020

cmsbuild added code-checks-approved upgrade-pending and removed code-checks-pending labels Jun 15, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 15, 2020

cmsbuild added the urgent label Jun 15, 2020

cmsbuild removed the tests-started label Jun 15, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 29, 2020

cmsbuild merged commit 9010c72 into cms-sw:master Jun 29, 2020

cmsbuild mentioned this pull request Jun 29, 2020

Revert "Run4-hgx247 Add some new features for HGCal" #30458

Merged

cmsbuild added tests-started and removed tests-rejected labels Jun 29, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-notrun tests-started labels Jun 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 30, 2020

cmsbuild added comparison-pending and removed comparison-available labels Jul 1, 2020

skinnari deleted the L1TK_11-2-pre1 branch July 1, 2020 11:26

cmsbuild added comparison-available and removed comparison-pending labels Jul 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update of L1 tracking (matching PR #30168) #30245

Update of L1 tracking (matching PR #30168) #30245

skinnari commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

fwyzard commented Jun 15, 2020

fwyzard commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

silviodonato commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020 •

edited

cmsbuild commented Jun 15, 2020

silviodonato commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 29, 2020 •

edited

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 30, 2020 •

edited

cmsbuild commented Jun 30, 2020 •

edited

skinnari commented Jun 30, 2020

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020 •

edited

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

Update of L1 tracking (matching PR #30168) #30245

Update of L1 tracking (matching PR #30168) #30245

Conversation

skinnari commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

fwyzard commented Jun 15, 2020

fwyzard commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

silviodonato commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020 • edited

cmsbuild commented Jun 15, 2020

silviodonato commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 29, 2020 • edited

cmsbuild commented Jun 29, 2020

cmsbuild commented Jun 30, 2020 • edited

cmsbuild commented Jun 30, 2020 • edited

skinnari commented Jun 30, 2020

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020 • edited

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jun 15, 2020 •

edited

cmsbuild commented Jun 29, 2020 •

edited

cmsbuild commented Jun 30, 2020 •

edited

cmsbuild commented Jun 30, 2020 •

edited

cmsbuild commented Jul 1, 2020 •

edited