Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herwig7p2 mpi settings #30196

Merged
merged 3 commits into from Jun 12, 2020
Merged

Conversation

EmyrClement
Copy link
Contributor

PR description:

Updating Herwig7 MPI settings for Herwig7.2

  • Rename of AlphaMZ to AlphaIn
  • Remove redundant/obsolete settings in tune configs
  • Added additional settings block that replicate the MPI model of Herwig7.1 in Herwig7.2, which is required for using the CH tunes.

PR validation:

Tested by generating MB events locally with these settings. Validation and details of the changes were presented at the GEN meeting on 25th May 2020

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30196/16035

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @EmyrClement for master.

It involves the following packages:

Configuration/Generator

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Jun 11, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6968/console Started: 2020/06/11 17:50

@cmsbuild
Copy link
Contributor

+1
Tested at: 98af765
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff52e9/6968/summary.html
CMSSW: CMSSW_11_2_X_2020-06-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff52e9/6968/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2779433
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2779382
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Jun 12, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants